-
Notifications
You must be signed in to change notification settings - Fork 19
refactor: change of a sync_apps.py logic #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
19447a2
ci: pip upgrade in container fix
d2ddcfc
refactor: sync_apps refactor
352a146
fix: compatibility between old and new style app-tenant configurations
ce5d542
removed currently not working appconfig_api located classes
164f802
added AppTenant and RootRepo factories to separate data from logic
02a20ff
rework of linters and tests
ae294e5
tst
76560cd
create factories for RootRepo and AppTenantConfig
1e211d6
refactor: prettier version of the custom config validator
f123228
refactor: moved app list verification outside sync_apps function
55e8670
refactor: rearranging of existing code, do not add customAppConfig va…
d1d412a
refactor: added apiVersion class for storing yaml property infirmation
4e46a2d
Complete refactoring
46b5439
Complete refactoring
06b1a60
Fix tests & mypy
03e2251
Fix tests and move classes out of sync_apps.py
d2993ae
Fix missing %s
52a2211
docs: fixed typo
makrelas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| def traverse_config(data, configver): | ||
| path = configver[1] | ||
| lookup = data | ||
| for key in path: | ||
| lookup = lookup[key] | ||
| return lookup |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.