refactor: change of a sync_apps.py logic #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 21, 2022 14:20
Move Root repository and Application Tenant configurations to be treated as object, including additional option of tenant repository traversal to obtain custom configurations. RootRepo and AppTennantConfig curenlty are explicitly defined in sync_apps.py as this is a POC to gather feedback about the direction to go.
niiku
requested changes
Nov 17, 2022
added 6 commits
November 25, 2022 18:38
niiku
reviewed
Dec 8, 2022
…lue file does not exist
makrelas
requested review from
niiku
and removed request for
christiansiegel
niiku
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Root repository and Application Tenant configurations to be treated as object, including additional option of tenant repository traversal to obtain custom configurations.
The idea behind it is to use this 2 classes in new commands (querying of the config of repo/listing tenant apps, getting user customizations etc.)
RootRepo and AppTennantConfig currently are explicitly defined in sync_apps.py (importing it externally requires even more of a tests rewrite), some of the linter tests are disabled as well - as this is a POC to gather feedback about the direction I'm going.