Skip to content

chore(cloudfront): backfill missing enums for cloudfront #33639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

chore(cloudfront): backfill missing enums for cloudfront #33639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55d8318
chore(cloudfront): backfill missing enums for cloudfront
paulhcsun Feb 28, 2025
1d558e8
Update packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts
Leo10Gama Mar 1, 2025
3f9c2dc
Update packages/aws-cdk-lib/aws-cloudfront/lib/function.ts
Leo10Gama Mar 1, 2025
3b3a706
Update packages/aws-cdk-lib/aws-cloudfront/lib/function.ts
Leo10Gama Mar 1, 2025
c4a2b60
Merge branch 'main' into backfill-enums/cloudfront
paulhcsun Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,7 @@ export enum OriginProtocolPolicy {
export enum SSLMethod {
SNI = 'sni-only',
VIP = 'vip',
STATIC_IP = 'static-ip',
}

/**
Expand Down
10 changes: 10 additions & 0 deletions packages/aws-cdk-lib/aws-cloudfront/lib/function.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,16 @@ export enum FunctionEventType {
* The viewer-response specifies the outgoing response
*/
VIEWER_RESPONSE = 'viewer-response',

/**
* The origin-request specifies the incoming request
*/
ORIGIN_REQUEST = 'origin-request',

/**
* The origin-response specifies the outgoing response
*/
ORIGIN_RESPONSE = 'origin-response',
Copy link
Contributor

@samson-keung samson-keung Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new enum values do not seem right. The origin-X events are only available to Lambda@Edge functions but not CloudFront functions: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/edge-functions-choosing.html

}

/**
Expand Down
Loading