chore(cloudfront): backfill missing enums for cloudfront #33639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo10Gama
reviewed
Mar 1, 2025
Member
|
This one has non-trivial conflicts to go through. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
samson-keung
suggested changes
Mar 3, 2025
| /** | ||
| * The origin-response specifies the outgoing response | ||
| */ | ||
| ORIGIN_RESPONSE = 'origin-response', |
Contributor
There was a problem hiding this comment.
These new enum values do not seem right. The origin-X events are only available to Lambda@Edge functions but not CloudFront functions: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/edge-functions-choosing.html
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
backfill missing enums for cloudfront
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license