Skip to content

Remove dockerhub login step and use ECR public gallery ubuntu image #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Remove dockerhub login step and use ECR public gallery ubuntu image #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/canary/Dockerfile.canary
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:18.04
FROM public.ecr.aws/ubuntu/ubuntu:18.04

# Build time parameters
ARG SERVICE=sagemaker
Expand Down
3 changes: 0 additions & 3 deletions test/canary/canary.buildspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ phases:
- aws ecr get-login-password --region $CLUSTER_REGION | docker login --username AWS --password-stdin $ECR_CACHE_URI || true
- docker pull ${ECR_CACHE_URI}:latest --quiet || true

# Login to dockerhub to avoid hitting throttle limit
- docker login -u $DOCKER_CONFIG_USERNAME -p $DOCKER_CONFIG_PASSWORD

# Build test image
- >
docker build -f ./test/canary/Dockerfile.canary . -t ${ECR_CACHE_URI}:latest
Expand Down