Remove dockerhub login step and use ECR public gallery ubuntu image #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryansteakley
approved these changes
Aug 11, 2021
Member
ryansteakley
left a comment
ryansteakley
left a comment
There was a problem hiding this comment.
Similiar, wait for tests to pass with v0.0.3
Contributor
Author
|
Tests on the release-v0.0.3 branch are in-progress. |
Contributor
Author
Tests ran successfully. |
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal, ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mbaijal
added a commit
that referenced
this pull request
Aug 12, 2021
) This is required so that we do not need to support dockerhub and its credentials. 1. Remove dockerhub login step from the codebuild spec file. 2. Use [ECR public gallery ubuntu image](https://gallery.ecr.aws/ubuntu/ubuntu) in the Canary Docker Image instead ### Testing For testing I added this commit on top of the `canary` branch and pushed to a new upstream branch [`docker-on-ecr-on-canary-branch`](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/docker-on-ecr-on-canary-branch). Then ran the canary test job on this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required so that we do not need to support dockerhub and its credentials.
Testing
For testing I added this commit on top of the
canarybranch and pushed to a new upstream branchdocker-on-ecr-on-canary-branch. Then ran the canary test job on this branch.