Add additional keys to adopted resource spec #13
Conversation
|
@RedbackThomson is gonna rework this PR, sometime next week /hold |
ack-bot
added
the
do-not-merge/hold
RedbackThomson
force-pushed
the
additional-keys
branch
from
9bee77c to
eeb621f
Compare
apis/core/v1alpha1/identifiers.go
Outdated
| NameOrID *string `json:"nameOrID,omitempty"` | ||
| // AdditionalKeys represents any additional arbitrary identifiers used when | ||
| // describing the target resource. | ||
| AdditionalKeys map[string]*string `json:"additionalKeys,omitempty"` |
There was a problem hiding this comment.
Any reason this is map[string]*string instead of map[string]string?
There was a problem hiding this comment.
I was using the other *string fields as reference. Is there a hard and fast rule to when we should use *string over string?
There was a problem hiding this comment.
The use of map[string]*string is really an aws-sdk-go thing. Since this isn't an aws-sdk-go shape field, I just thought it would make more sense to use a standard map[string]string. Pointer types generally signal optional fields (except for aws-sdk-go, which makes everything a pointer type, unfortunately).
There was a problem hiding this comment.
Fair enough. I've updated all unnecessary *string to string types for the adopted resource APIs.
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…de (#115) Related to #105 and aws-controllers-k8s/runtime#13 Description of changes: - replace nil pointer checks with string zero value checks - replace `string` value assignment with `string` ptr assignments By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…de (aws-controllers-k8s#115) Related to aws-controllers-k8s#105 and aws-controllers-k8s/runtime#13 Description of changes: - replace nil pointer checks with string zero value checks - replace `string` value assignment with `string` ptr assignments By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…de (aws-controllers-k8s#115) Related to aws-controllers-k8s#105 and aws-controllers-k8s/runtime#13 Description of changes: - replace nil pointer checks with string zero value checks - replace `string` value assignment with `string` ptr assignments By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
4 participants
Issue #, if available: aws-controllers-k8s/community#766
Some resources require more than an ARN/Name/ID to describe a single resource. This PR adds an
additionalKeysfield to theAWSIdentifiersto allow for arbitrary identifiers as needed by any resources.Generator code to support this change: aws-controllers-k8s/code-generator#62