Correct type mismatch errors in SetResourceIdentifiers generated code
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code - replace nil pointer checks with zero string value checks - Replace `string` value assignment with `string` ptr assignments
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
that referenced
this pull request
Jul 5, 2021
Related to #115 For some controllers we use `ReadMany` operations to read resource current state. For these operations we need to lookup for identifiers ending with `Names` and not `Name`. e.g `RepositoryNames` in `DescribeRepositories` operation. Description of changes: - Add primary identifiers for `ReadMany` operations By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
to a-hilaly/ack-code-generator
that referenced
this pull request
Jul 6, 2021
…de (aws-controllers-k8s#115) Related to aws-controllers-k8s#105 and aws-controllers-k8s/runtime#13 Description of changes: - replace nil pointer checks with string zero value checks - replace `string` value assignment with `string` ptr assignments By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
added a commit
to a-hilaly/ack-code-generator
that referenced
this pull request
Jul 6, 2021
…s#116) Related to aws-controllers-k8s#115 For some controllers we use `ReadMany` operations to read resource current state. For these operations we need to lookup for identifiers ending with `Names` and not `Name`. e.g `RepositoryNames` in `DescribeRepositories` operation. Description of changes: - Add primary identifiers for `ReadMany` operations By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson
pushed a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jul 8, 2021
…de (aws-controllers-k8s#115) Related to aws-controllers-k8s#105 and aws-controllers-k8s/runtime#13 Description of changes: - replace nil pointer checks with string zero value checks - replace `string` value assignment with `string` ptr assignments By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson
pushed a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jul 8, 2021
…s#116) Related to aws-controllers-k8s#115 For some controllers we use `ReadMany` operations to read resource current state. For these operations we need to lookup for identifiers ending with `Names` and not `Name`. e.g `RepositoryNames` in `DescribeRepositories` operation. Description of changes: - Add primary identifiers for `ReadMany` operations By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #105 and aws-controllers-k8s/runtime#13
Description of changes:
stringvalue assignment withstringptr assignmentsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.