Skip to content

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Feb 9, 2023

In the previous commit, we removed the environment variables
not the flags...

Signed-off-by: Amine Hilaly [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In the previous commit we removed the environemnt variables...

Signed-off-by: Amine Hilaly <[email protected]>
@ack-prow ack-prow bot requested review from RedbackThomson and jljaco February 9, 2023 19:14
@ack-prow ack-prow bot added the approved label Feb 9, 2023
@jljaco
Copy link
Contributor

jljaco commented Feb 9, 2023

Related to
#410
#409

@jljaco
Copy link
Contributor

jljaco commented Feb 9, 2023

/lgtm

@ack-prow ack-prow bot assigned jljaco Feb 9, 2023
@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jljaco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit a8f49b0 into aws-controllers-k8s:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants