Fix default value of --reconcile-resource flag in deployment.yaml
#410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The runtime expects `--reconcile-resource-resync-seconds` to be an array of string values. While in deployment.yaml we pass an empty string which is invalid for `runtime/pkg/config`. This patch fixes this issue by removing the `--reconcile-resource-resync-seconds` value Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
reconcile-flag-fix
branch
from
5626f82 to
f785f0a
Compare
|
New changes are detected. LGTM label has been removed. |
|
This was to get tests passing in #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime expects
--reconcile-resource-resync-secondsto be an arrayof string values. While in deployment.yaml we pass an empty string which
is invalid for
runtime/pkg/config.This patch fixes this issue by removing the
--reconcile-resource-resync-secondsvalueSigned-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.