Skip to content

Add helm variable for Role Labels #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add helm variable for Role Labels #367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02483b
New helm variable to provide clusterRole label option
akartsky Sep 20, 2022
2e0961a
Add label for role
akartsky Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions templates/helm/templates/_controller-role-kind-patch.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ kind: ClusterRole
metadata:
creationTimestamp: null
name: ack-{{ .ServicePackageName }}-controller
labels:
{{ "{{- range $key, $value := .Values.clusterRole.labels }}" }}
{{ "{{ $key }}: {{ $value | quote }}" }}
{{ "{{- end }}" }}
{{ "{{ else }}" }}
kind: Role
metadata:
Expand Down
8 changes: 8 additions & 0 deletions templates/helm/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@
],
"type": "object"
},
"clusterRole": {
"description": "ClusterRole settings",
"properties": {
"labels": {
"type": "object"
}
}
},
"metrics": {
"description": "Metrics settings",
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions templates/helm/values.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ deployment:
# Which priorityClassName to set?
# See: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#pod-priority
priorityClassName: ""

clusterRole:
labels: {}

metrics:
service:
Expand Down