Add helm variable for Role Labels #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akartsky
changed the title
|
/test s3-controller-test |
akartsky
changed the title
akartsky
changed the title
akartsky
changed the title
|
/retest |
|
/test s3-controller-test |
|
S3 test failing with |
akartsky
force-pushed
the
helm_clusterrole_label
branch
from
e177e8e to
d42b34c
Compare
|
/approve |
RedbackThomson
changed the title
akartsky
changed the title
|
@akartsky @surajkota the s3-controller test failures are not related to this PR |
a-hilaly
reviewed
Sep 20, 2022
akartsky
force-pushed
the
helm_clusterrole_label
branch
from
d42b34c to
2e0961a
Compare
|
@akartsky: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test dynamodb-controller-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, akartsky, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Vandita2020
pushed a commit
to Vandita2020/ack-code-generator
that referenced
this pull request
Oct 24, 2022
Provide option for users to specify Role labels in helm values This is useful when using [k8s clusterRole aggregation](https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles) We can use aggregation rule labels to give other applications access to ack resources (Eg: Kubeflow in our case) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide option for users to specify Role labels in helm values
This is useful when using k8s clusterRole aggregation
We can use aggregation rule labels to give other applications access to ack resources (Eg: Kubeflow in our case)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.