Skip to content

Conversation

vijtrip2
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1328

Description of changes:

  • If the NilFieldPath check is empty, which means that "Tag" field is present at top level, initialize the existing tags inside "AWSResourceManager.ExistingTags" method
  • Validated by locally testing using apigatewayv2-controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vijtrip2 vijtrip2 requested a review from jaypipes June 10, 2022 17:41
@ack-bot ack-bot requested a review from brycahta June 10, 2022 17:41
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 10, 2022

@vijtrip2: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
s3-olm-test 0f4aef8 link /test s3-olm-test
s3-controller-test 0f4aef8 link /test s3-controller-test
dynamodb-controller-test 0f4aef8 link /test dynamodb-controller-test
ecr-controller-test 0f4aef8 link /test ecr-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is exactly what I'm seeing. ++

@ack-bot
Copy link
Collaborator

ack-bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit a133935 into aws-controllers-k8s:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants