EnsureTags injecting erroneous tag values #1328
Description
In generating latest RDS controller for ACK runtime v0.19.0, I am seeing the following errors in the controller logs during tests:
1.6548499531724842e+09 ERROR controller.dbparametergroup Reconciler error {"reconciler group": "rds.services.k8s.aws", "reconciler kind": "DBParameterGroup", "name": "pg13-standard", "namespace": "default", "error": "InvalidParameterValue: Tag values may only contain unicode letters, digits, whitespace, or one of these symbols: _ . : / = + - @\n\tstatus code: 400, request id: dc460d16-2f8f-4b73-bff8-232ea1aff41e"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227
If I had to guess, what is happening is that the %K8S_NAMESPACE% and similar interpolation variables inside ensured tag values are not being properly interpolated or the EnsureTags is not ensuring that in the case of a missing environment variable or needed interpolation target, that the end tag value is actually valid...