Skip to content

Conversation

mbaijal
Copy link
Contributor

@mbaijal mbaijal commented Sep 14, 2021

Issue #, if available:
Fixing comment on previous PR #40

Description of changes:

  • Use the CreationTime to update LastModifiedTime
  • Add associated test to check LastModifiedTime

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
@mbaijal mbaijal self-assigned this Sep 14, 2021
@mbaijal mbaijal marked this pull request as draft September 14, 2021 23:00
@mbaijal mbaijal marked this pull request as ready for review September 14, 2021 23:01
@mbaijal mbaijal force-pushed the fix-status-fields-0.0.3 branch from a46f7a6 to 36af6dd Compare September 15, 2021 07:58
Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

is this PR still WIP?

@mbaijal mbaijal changed the title [WIP] Use the CreationTime to update LastModifiedTime Use the CreationTime to update LastModifiedTime Sep 15, 2021
@ack-bot ack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2021
@surajkota
Copy link
Member

/test

@surajkota
Copy link
Member

/test applicationautoscaling-kind-e2e

@surajkota
Copy link
Member

/approve

@vijtrip2
Copy link
Contributor

/test applicationautoscaling-kind-e2e

@mbaijal
Copy link
Contributor Author

mbaijal commented Sep 15, 2021

/retest

@mbaijal mbaijal force-pushed the fix-status-fields-0.0.3 branch from e0bd3fd to d73bd31 Compare September 16, 2021 00:54
Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaijal, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 8eb6934 into aws-controllers-k8s:main Sep 16, 2021
ack-bot pushed a commit that referenced this pull request Sep 16, 2021
Issue #, if available:
release artifacts for release v0.1.0

Release Notes draft:
This release includes the following resources and updates:
 - Enables the AdoptedResource Feature for both `ScalableTarget` and `ScalingPolicy` ( #47 ).
 - Uses the server side `CreationTime` to set the `LastModifiedTime` the very first time ( #49 ).
 - Some release and helm test related changes ( #48 and #50).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants