-
Notifications
You must be signed in to change notification settings - Fork 20
Use the CreationTime to update LastModifiedTime #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the CreationTime to update LastModifiedTime #49
Conversation
a46f7a6
to
36af6dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
is this PR still WIP?
/test |
/test applicationautoscaling-kind-e2e |
/approve |
/test applicationautoscaling-kind-e2e |
/retest |
e0bd3fd
to
d73bd31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: release artifacts for release v0.1.0 Release Notes draft: This release includes the following resources and updates: - Enables the AdoptedResource Feature for both `ScalableTarget` and `ScalingPolicy` ( #47 ). - Uses the server side `CreationTime` to set the `LastModifiedTime` the very first time ( #49 ). - Some release and helm test related changes ( #48 and #50). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
Fixing comment on previous PR #40
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.