Enable AdoptedResource using latest code-gen logic for ScalableTarget #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaijal
commented
Sep 14, 2021
mbaijal
force-pushed
the
fix-adopted-resource-ids-post-release-nick
branch
from
7caea06 to
bed96a7
Compare
RedbackThomson
suggested changes
Sep 14, 2021
mbaijal
commented
Sep 14, 2021
| describe_response = sagemaker_endpoint_describe_scaling_policy( | ||
| resource_id, policy_name | ||
| ) | ||
| if len(describe_response["ScalingPolicies"]) > 0: |
surajkota
approved these changes
Sep 14, 2021
| sagemaker_endpoint_delete_scaling_policy, | ||
| ) | ||
|
|
||
| TARGET_RESOURCE_PLURAL = "scalabletargets" |
There was a problem hiding this comment.
nit: these can move to common config
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
Issue #, if available: release artifacts for release v0.1.0 Release Notes draft: This release includes the following resources and updates: - Enables the AdoptedResource Feature for both `ScalableTarget` and `ScalingPolicy` ( #47 ). - Uses the server side `CreationTime` to set the `LastModifiedTime` the very first time ( #49 ). - Some release and helm test related changes ( #48 and #50). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are the same as #42 but created a separate PR because I wanted preserve the changes of that PR.
TODO:
Description of changes:
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.