Add creationTime to Status for ScalableTarget and ScalingPolicy resources #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
reviewed
Sep 7, 2021
mbaijal
changed the title
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Sep 8, 2021
…183) Issue #, if available: aws-controllers-k8s/community#932 Description of changes: `getMemberByPath` checks the shape type as it loops through members to ensure lists are handled correctly. Currently I have simply ignored the empty element created by the splitting of the string on the single dot instead of handling the double dot notation explicitly. Open to comments. Also added a Unit Test for the same. Testing 1. Generated code for ApplicationAutoscaling and ensured CreationTime field now works as expected. Linked changes [in this PR](aws-controllers-k8s/applicationautoscaling-controller#39). 2. Ensured that the SageMaker Controller can be generated using new changes with no diff as expected. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sure, but I am creating a separate PR for that since this is also a demo of the associated Code-gen change. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, mbaijal, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
Description of changes: release artifacts for release v0.0.3 Release Notes draft: This release includes the following resources and updates: - Update ACK Runtime from 0.13.0 to 0.13.2 ( #41 ) - Please refer to https://github.com/aws-controllers-k8s/runtime/releases for a detailed list of changes - The Status field now includes the CreationTime as recorded by the server ( #39 ). - The Status field also includes the `LastModifiedTime` which records the time the resource was last updated ( #40 ). - Includes updates to the README file ( #37 ) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-controllers-k8s/community#932
Description of changes:
Add creationTime to Status for ScalableTarget and ScalingPolicy resources based off of code gen changes in this PR.
TODO: Add required check to the existing integration test.
Testing
Manually tested that the field is present in the Status of the
kubectl getresponse.Kind tests pass locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.