Merge v1.14.9

[SuperFluffy]

This patch was constructed using these steps:

$ git branch upstream_v1.14.9_squashed v1.14.9 && git checkout upstream_v1.14.9_squashed
$ git rebase -i v1.14.8 // squash everything from release v1.14.8 up to v1.14.9 into one commit
$ git switch -c update_v1.14.9  update_v1.14.8
$ git cherry-pick upstream_v1.14.9_squashed

This patch is based on branch https://github.com/astriaorg/astria-geth/tree/update_v1.14.8 of PR #101. Merging is blocked until that PR as been accepted and merged.

The merge conflicts that required resolution can be seen by following the steps above. It is recommended to use the zdiff3 merge strategy.

Notable conflicts that required resolution:

consensus/clique/clique_test.go: checked out upstream version and commented out (as done in the previous Astria blame)

• core/genesis.go: move the astria specific bits from ToBlock to the new upstream toBlockWithRoot.
• core/state_processor_test.go: just some imports
• core/state_transition.go: add new upstream field SkipFromEOACheck to TransactionToMessage
• core/txpool/legacypool/legacypool_test.go: in TestRemoveTxSanity use state.NewDatabaseForTesting, update removed third argument to state.New (snapshot trees)
• core/types/transaction_signing: shift from if-blocks to switch statement
• core/vm/evm.go: resolved the new precompiles field clashing with precompileManager; these seem to work transparently side by side, because func precompiles with the EVM receiver is still present; note that all code that calls out to precompiles using the new vm.ActivePrecompiledContracts only has access to the vanilla upstream precompiles, not the Astria specific ones. This seems to be the case for tracers and the new simulate API, possibly others (also having vm.ActivePrecompiles in mind).
• core/vm/instructions_test.go: in TestOpTStore, NewDatabaseForTesting replaces NewDatabase; added a comment on upstream block context being different for Astria
• eth/catalyst/api_test.go: changed equalBody to treat deposits that are nil and empty slice the same; astria-geth does not populate the requests and transactions fields in the core/types/block/Body struct, which breaks tests.
• ethclient/simulated/backend_test.go: resolved conflict in TestForkResendTx by checking out the upstream version, commenting it out and adding a comment for why it is commented out.
• internal/ethapi/api_test.go: conflict in TestTransactionBlobTx resolved by taking upstream version, commenting it out, adding a comment for why it is commented out.
• miner/worker.go: moved generateWork a few lines up to match with upstream. Added a comment why execution is not
  being timed out. Add a Prague section to generateWork introduced in v1.14.9.
• go.mod: x/sys to v0.22.0 (upstream), x/text to v0.16.0 (astria) + go mod tidy -go=1.22

---

params: begin v1.14.9 release cycle

go.mod: remove github.com/julienschmidt/httprouter (#30290)

build: run 'go mod tidy' check as part of lint (#30291)

core/txpool/blobpool: fix error message (#30247)

the validation process only checks for 'less than', which is inconsistent with the error output

go.mod: upgrade to pebble v1.1.2 (#30297)

Includes a fix for MIPS32 support.

Pebble release:
https://github.com/cockroachdb/pebble/releases/tag/v1.1.2 Key fix for mips32:
cockroachdb/pebble@9f3904a (also the only change from v1.1.1.

core: only compute state root once (#30299)

This PR refactors the genesis initialization a bit, s.th. we only compute the blockhash once instead of twice as before (during hashAlloc and flushAlloc)

This will significantly reduce the amount of memory allocated during genesis init

---

Co-authored-by: Gary Rong [email protected]

.golangci.yml: remove lint warning for TxLookupLimit

eth/fetcher: always expect transaction metadata in announcement (#30288)

This pull request drops the legacy transaction retrieval support from before eth68, adding the restrictions that transaction metadata must be provided along with the transaction announment.

eth/ethconfig: remove LES server config (#30298)

eth/tracers/js: add coinbase addr to ctx (#30231)

Add coinbase address to javascript tracer context.

This PR adds the coinbase address to jsTracer.ctx, allowing access to the coinbase address (fee receipient) in custom JavaScript tracers.

Example usage:

result: function(ctx) {
  return toAddress(ctx.coinbase);
}

This change enables custom tracers to access coinbase address, previously unavailable, enhancing their capabilities to match built-in tracers.

eth: dial nodes from discv5 (#30302)

Here I am adding a discv5 nodes source into the p2p dial iterator. It's an improved version of #29533.

Unlike discv4, the discv5 random nodes iterator will always provide full ENRs. This means we can apply filtering to the results and will only try dialing nodes which explictly opt into the eth protocol with a matching chain.

I have also removed the dial iterator from snap. We don't have an official DNS list for snap anymore, and I doubt anyone else is running one. While we could potentially filter for snap on discv5, there will be very few nodes announcing it, and the extra iterator would just stall the dialer.

---

Co-authored-by: lightclient [email protected]

beacon/light: handle endpoint URL more gracefully (#30306)

blsync was failing if the light endpoint it was provided ended with a /. This change should handle the joining more gracefully.

core: remove withdrawal length check for state processor (#30286)

The withdrawal length is already verified by the beacon consensus package, so the check in the state processor is a duplicate.

vm: simplify error handling in vm.EVM.create() (#30292)

To allow all error paths in vm.EVM.create() to consume the necessary gas, there is currently a pattern of gating code on if err == nil instead of returning as soon as the error occurs. The same behaviour can be achieved by abstracting the gated code into a method that returns immediately on error, improving readability and thus making it easier to understand and maintain.

internal/build: include git-date on detached head (#30320)

When we are building in detached head, we cannot easily obtain the same information as we can if we're in non-detached head.

However, one thing we can obtain is the git-hash and git-date. Currently, we omit to include the git-date into the build-info, which causes problem for reproducable builds which are on a detached head.

This change fixes it to include the date-info always.

build: remove mantic from ppa builds (#30322)

removes ppa-build for ubuntu mantic

gitignore: ignore upload-artefacts (#30325)

Our WriteArchive, used by ci builder, creates files in the repo root,in order to upload. After we've built the amd64-builds, we create the uploads, and cause the repo to be flagged as dirty for the remaining builds.

This change fixes it by adding the artefacts to gitignore. Closes #30324

eth/catalyst: ensure period zero mode leaves no pending txs in pool (#30264)

closes #29475, replaces #29657, #30104

Fixes two issues. First is a deadlock where the txpool attempts to reorg, but can't complete because there are no readers left for the new txs subscription. Second, resolves a problem with on demand mode where txs may be left pending when there are more pending txs than block space.

Co-authored-by: Martin Holst Swende [email protected]

accounts/abi: handle ABIs with contract type parameter (#30315)

convert parameter of type contract to the basic address type ---------

Co-authored-by: Martin HS [email protected]

core/rawdb: drop MigrateTable (#30331)

These are the leftovers from #24028.

core/vm: reuse Memory instances (#30137)

This PR adds a sync.Pool to reuse instances of Memory in EVMInterpreter.

build: attempt at reproducible builds (#30321)

This PR implements the conclusions from
ethereum/go-ethereum#28987 (comment), that is:

Building with --strip-all as a ld-flag to the cgo linker, to remove symbols. Without that, some spurious reference to a temporary file is included into the kzg-related library.

Building with --build-id=none, to avoid putting a build id into the file.

all: update to go version 1.23.0 (#30323)

This PR updates the version of go used in builds and docker to 1.23.0. Release notes: https://go.dev/doc/go1.23

More importantly, following our policy of maintaining the last two versions (which now becomes 1.23 and 1.22), we can now make use of the things that were introduced in 1.22: https://go.dev/doc/go1.22

Go 1.22 makes two changes to “for” loops.

• each iteration creates new variables,
• for loops may range over integers

Other than that, some interesting library changes and other stuff.

rpc: add timeout to rpc client Unsubscribe (#30318)

Fixes #30156

This adds a repro of the linked issue. I fixed it by adding a timeout when issuing the call to unsubscribe.

cmd/devp2p: require dns:read, dns:edit permissions for cloudflare deploy (#30326)

This PR adds the dns:read and dns:edit permissions to the required set of permissions checked before deploying an ENR tree to Cloudflare. These permissions are necessary for a successful publish.

Background:
The current logic for devp2p dns to-cloudflare checks for zone:edit and zone:read permissions. However, when running the command with only these two permissions, the following error occurs:

wrong permissions on zone REMOVED-ZONE: map[#zone:edit:false #zone:read:true]

Adding zone:read and zone:edit to the API token led to a different error:

INFO [08-19|14:06:16.782] Retrieving existing TXT records on pos-nodes.hardfork.dev
Authentication error (10000)

This suggested that additional permissions were required. I added dns:read, but encountered another error:

INFO [08-19|14:11:42.342] Retrieving existing TXT records on pos-nodes.hardfork.dev
INFO [08-19|14:11:42.851] Updating DNS entries
failed to publish REMOVED.pos-nodes.hardfork.dev: Authentication error (10000)

Finally, after adding both dns:read and dns:edit permissions, the command executed successfully with the following output:

INFO [08-19|14:13:07.677] Checking Permissions on zone REMOVED-ZONE
INFO [08-19|14:13:08.014] Retrieving existing TXT records on pos-nodes.hardfork.dev
INFO [08-19|14:13:08.440] Updating DNS entries
INFO [08-19|14:13:08.440] "Updating pos-nodes.hardfork.dev from \"enrtree-root:v1 e=FSED3EDKEKRDDFMCLP746QY6CY l=FDXN3SN67NA5DKA4J2GOK7BVQI seq=1 sig=Glja2c9RviRqOpaaHR0MnHsQwU76nJXadJwFeiXpp8MRTVIhvL0LIireT0yE3ETZArGEmY5Ywz3FVHZ3LR5JTAE\" to \"enrtree-root:v1 e=AB66M4ULYD5OYN4XFFCPVZRLUM l=FDXN3SN67NA5DKA4J2GOK7BVQI seq=1 sig=H8cqDzu0FAzBplK4g3yudhSaNtszIebc2aj4oDm5a5ZE5PAg-xpCnQgVE_53CsgsqQpalD9byafx_FrUT61sagA\""
INFO [08-19|14:13:16.932] Updated DNS entries                      new=32 updated=1 untouched=100
INFO [08-19|14:13:16.932] Deleting stale DNS entries
INFO [08-19|14:13:24.663] Deleted stale DNS entries                count=31

With this PR, the required permissions for deploying an ENR tree to Cloudflare now include zone:read, zone:edit, dns:read, and dns:edit. The initial check now includes all of the necessary permissions and indicates in the error message which permissions are missing:

INFO [08-19|14:17:20.339] Checking Permissions on zone REMOVED-ZONE
wrong permissions on zone REMOVED-ZONE: map[#dns_records:edit:false #dns_records:read:false #zone:edit:false #zone:read:true]

all: clean up goerli flag and config (#30289)

Co-authored-by: lightclient [email protected]

cmd/utils,p2p: enable discv5 by default (#30327)

travis.yml: use focal for builds (#30319)

trie: use go-verkle helper for speedier (*VerkleTrie).RollBackAccount (#30242)

This is a performance improvement on the account-creation rollback code required for the archive node to support verkle. It uses the utility function DeleteAtStem to remove code and account data per-group instead of doing it leaf by leaf.

It also fixes an index bug, as code is chunked in 31-byte chunks, so comparing with the code size should use 31 as its stride.

---

Co-authored-by: Felix Lange [email protected]

eth/protocols/eth: handle zero-count header requests (#30305)

Proper fix for handling count=0 get header requests.

https://en.wikipedia.org/wiki/Count_Zero

eth/tracers: avoid panic in state test runner (#30332)

Make tracers more robust by handling nil receipt as input. Also pass in a receipt with gas used in the state test runner. Closes ethereum/go-ethereum#30117.

---

Co-authored-by: Sina Mahmoodi [email protected]

build: fix hash for go1.23.0.linux-riscv64.tar.gz (#30335)

build: fix hash for go1.23.0.linux-riscv64.tar.gz

build: make go buildid static (#30342)

The previous clearing of buildid did fully work, turns out we need to set it in ldflags

The go buildid is the only remaining hurdle for reproducible builds, see ethereum/go-ethereum#28987 (comment)

This PR changes the go build id application note to say literally none

golang/go#33772 (comment):

This difference is due to the .note.go.buildid section added by the
linker. It can be set to something static e.g. -ldflags=-buildid= (empty string) to gain reproducibility.

trie: avoid un-needed map copy (#30343)

This change avoids the an unnecessary map copy if the preimage recording is not enabled.

beacon/blsync: better error information in test (#30336)

this change reports the error instead of ignoring it

beacon/light/sync: basic tests for rangeLock (#30269)

adds simple tests for lock and firstUnlocked method from rangeLock type

---

Co-authored-by: lightclient [email protected]

build: debug travis build (#30344)

debugging travis build pipeline

gitignore: ignore build signatures (#30346)

Ignore files are generated during signing of download-binaries, which 'dirty' the vcs for subsequent builds.

doc: update 2021-08-22-split-postmortem (#30351)

Update 2021-08-22-split-postmortem

core: implement EIP-2935 (#29465)

https://eips.ethereum.org/EIPS/eip-2935

---

Co-authored-by: Guillaume Ballet [email protected]
Co-authored-by: Ignacio Hagopian [email protected]
Co-authored-by: Martin HS [email protected]

core: add metrics for state access (#30353)

This pull request adds a few more performance metrics, specifically:

• The average time cost of an account read
• The average time cost of a storage read
• The rate of account reads
• The rate of storage reads

core/state: fix trie prefetcher for verkle (#30354)

This pull request fixes the panic issue in prefetcher once the verkle is activated.

p2p/discover: fix Write method in metered connection (#30355)

WriteToUDP was never called, since meteredUdpConn exposed directly all the methods from the underlying UDPConn interface.

This fixes the discover/egress metric never being updated.

accounts/abi/bind, ethclient/simulated: check SendTransaction error in tests (#30349)

In few tests the returned error from SendTransaction is not being checked. This PR checks the returned err in tests.

Returning errors also revealed tx in TestCommitReturnValue is not actually being sent, and returns err only replay-protected (EIP-155) transactions allowed over RPC. Fixed the transaction by using the testTx function.

core/state: semantic journalling (part 1) (#28880)

This is a follow-up to #29520, and a preparatory PR to a more thorough change in the journalling system.

This PR hides the journal-implementation details away, so that the statedb invokes methods like JournalCreate, instead of explicitly appending journal-events in a list. This means that it's up to the journal whether to implement it as a sequence of events or aggregate/merge events.

This PR also makes it so that management of valid snapshots is moved inside the journal, exposed via the methods Snapshot() int and RevertToSnapshot(revid int, s *StateDB).

JournalSetCode journals the setting of code: it is implicit that the previous values were "no code" and emptyCodeHash. Therefore, we can simplify the setCode journal.

The self-destruct journalling is a bit strange: we allow the selfdestruct operation to be journalled several times. This makes it so that we also are forced to store whether the account was already destructed.

What we can do instead, is to only journal the first destruction, and after that only journal balance-changes, but not journal the selfdestruct itself.

This simplifies the journalling, so that internals about state management does not leak into the journal-API.

Preimages were, for some reason, integrated into the journal management, despite not being a consensus-critical data structure. This PR undoes that.

---

Co-authored-by: Gary Rong [email protected]

signer/core/apitypes: support fixed size arrays for EIP-712 typed data (#30175)

When attempting to hash a typed data struct that includes a type reference with a fixed-size array, the validation process fails. According to EIP-712, arrays can be either fixed-size or dynamic, denoted by Type[n] or Type[] respectively, although it appears this currently isn't supported.

This change modifies the validation logic to accommodate types containing fixed-size arrays.

consensus/beacon, core/types: add verkle witness builder (#30129)

This PR adds the bulk verkle witness+proof production at the end of block production. It reads all data from the tree in one swoop and produces a verkle proof.

Co-authored-by: Felix Lange [email protected]

trie, core/state: Nyota EIP-6800 & EIP-4762 spec updates (#30357)

This PR implements changes related to
EIP-6800 and EIP-4762 spec updates.

A TL;DR of the changes is that Version, Balance, Nonce and CodeSize are encoded in a single leaf named BasicData. For more details, see the Header Values table in
EIP-6800.

The motivation for this was simplifying access event patterns, reducing code complexity, and, as a side effect, saving gas since fewer leaf nodes must be accessed.

---

Co-authored-by: Guillaume Ballet [email protected]
Co-authored-by: Felix Lange [email protected]

Include tracerConfig in created tracing test (#30364)

Fixes the tracer test filler for when there is tracerConfig.

core/state: pull the verkle trie from prefetcher for empty storage root (#30369)

This pull request fixes a flaw in prefetcher.

In verkle tree world, both accounts and storage slots are committed into a single tree instance for state hashing. If the prefetcher is activated, we will try to pull the trie for the prefetcher for performance speedup.

However, we had a special logic to skip pulling storage trie if the storage root is empty. While it's true for merkle as we have nothing to do with an empty storage trie, it's totally wrong for verkle. The consequences for skipping pulling is the storage changes are committed into trie A, while the account changes are committed into trie B (pulled from the prefetcher), boom.

funding.json: add funding information file (#30385)

Adds a list of funding identifiers.

all: implement EIP-6110, execution layer triggered deposits (#29431)

This PR implements EIP-6110: Supply validator deposits on chain. It also sketches out the base for Prague in the engine API types.

all: remove forkchoicer and reorgNeeded (#29179)

This PR changes how sidechains are handled.

Before the merge, it was possible to import a chain with lower td and not set it as canonical. After the merge, we expect every chain that we get via InsertChain to be canonical. Non-canonical blocks can still be inserted with InsertBlockWIthoutSetHead.

If during the InsertChain, the existing chain is not canonical anymore, we mark it as a sidechain and send the SideChainEvents normally.

core: fix compilation error (#30394)

un-borks a compilation error from a recent merge to master

all: remove funding verifier (#30391)

Now that verification is done, we can remove the funding information.

node: fix flaky jwt-test (#30388)

This PR fixes a flaky jwt-test.

The test is a jwt "from one second in the future". The test passes; the reason for this is that the CI-system is slow, and by the time the jwt is actually evaluated, that second has passed, and it's no longer future.

Alternative to #30380

build: increase go test timeout (#30398)

This increases the timeout for the go tests on ci, this should prevent travis from erroring.

see:
https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/625803693

core/state: state reader abstraction (#29761)

This pull request introduces a state.Reader interface for state accessing.

The interface could be implemented in various ways. It can be pure trie only reader, or the combination of trie and state snapshot. What's more, this interface allows us to have more flexibility in the future, e.g. the
archive reader (for accessing archive state).

Additionally, this pull request removes the following metrics

• chain/snapshot/account/reads
• chain/snapshot/storage/reads

core/state: get rid of field pointer in journal (#30361)

This pull request replaces the field pointer in journal entry with the field itself, specifically the address of mutated account.

While it will introduce the extra allocation cost, but it's easier for code reading. Let's measure the overhead overall to see if the change is acceptable or not.

build: upgrade -dlgo version to Go 1.23.1 (#30404)

New security fix:
https://groups.google.com/g/golang-announce/c/K-cEzDeCtpc

internal/ethapi: eth_multicall (#27720)

This is a successor PR to #25743. This PR is based on a new iteration of the spec: ethereum/execution-apis#484.

eth_multicall takes in a list of blocks, each optionally overriding fields like number, timestamp, etc. of a base block. Each block can include calls. At each block users can override the state. There are extra features, such as:

• Include ether transfers as part of the logs
• Overriding precompile codes with evm bytecode
• Redirecting accounts to another address

This PR includes the following breaking changes:

• Block override fields of eth_call and debug_traceCall have had the following fields renamed
  • coinbase -> feeRecipient
  • random -> prevRandao
  • baseFee -> baseFeePerGas

---

Co-authored-by: Gary Rong [email protected]
Co-authored-by: Martin Holst Swende [email protected]

eth/fetcher: fix blob transaction propagation (#30125)

This PR fixes an issue with blob transaction propagation due to the blob transation txpool rejecting transactions with gapped nonces. The specific changes are:

• fetch transactions from a peer in the order they were announced to minimize nonce-gaps (which cause blob txs to be rejected

• don't wait on fetching blob transactions after announcement is received, since they are not broadcast

Testing:

• unit tests updated to reflect that fetch order should always match tx announcement order
• unit test added to confirm blob transactions are scheduled immediately for fetching
  • running the PR on an eth mainnet full node without incident so far

---

Signed-off-by: Roberto Bayardo [email protected]
Co-authored-by: Gary Rong [email protected]

core/state/snapshot: port changes from 29995 (#30040)

process.

Specifically, it attempts to stop the state snapshot generation, which could potentially
cause the system to halt if the generation is not currently running.

This pull request ports the changes made in #29995 and fixes the flaw.

beacon/engine/types: remove PayloadV4 (#30415)

h/t @MariusVanDerWijden for finding and fixing this on devnet 3.

I made the mistake of thinking PayloadVersion was correlated with the GetPayloadVX method, but it actually tracks which version of PayloadAttributes were passed to forkchoiceUpdated. So far, Prague does not necessitate a new version of fcu, so there is no need for PayloadV4.

Co-authored-by: Marius van der Wijden [email protected]

core/vm: remove panic when address is not present (#30414)

Remove redundant address presence check in makeGasSStoreFunc.

This PR simplifies the makeGasSStoreFunc function by removing the redundant check for address presence in the access list. The updated code now only checks for slot presence, streamlining the logic and eliminating unnecessary panic conditions.

This change removes the unnecessary address presence check, simplifying the code and improving maintainability without affecting functionality. The previous panic condition was intended as a canary during the testing phases (i.e. YOLOv2) and is no longer needed.

beacon/light/api: fixed blsync update query (#30421)

This PR fixes what ethereum/go-ethereum#30306 broke. Escaping the ? in the event sub query was fixed in that PR but it was still escaped in the updates request. This PR adds a URL params argument to httpGet and fixes updates query formatting.

eth/filters: prevent concurrent access in test (#30401)

use a mutex to prevent concurrent access to the api.filters map during TestPendingTxFilterDeadlock test

core/rawdb: more accurate description of freezer in docs (#30393)

fixes ethereum/go-ethereum#29793

core/state, core/vm: Nyota contract create init simplification (#30409)

Implementation of this EIP-4762
update.

---

Signed-off-by: Guillaume Ballet [email protected]
Co-authored-by: Tanishq Jasoria [email protected]

p2p/enode: add quic ENR entry (#30283)

Add quic entry to the ENR as proposed in
ethereum/consensus-specs#3644

---

Co-authored-by: lightclient [email protected]

core/tracing: fix copy/paste error+comments in reason listing (#30431)

Signed-off-by: Guillaume Ballet [email protected]

core/txpool/blobpool: avoid possible zero index panic (#30430)

This situation(len(txs) == 0) rarely occurs, but if it does, it will panic.

---

Co-authored-by: Martin HS [email protected]

core/rawdb: remove unused transition status state accessors (#30433)

internal: run tests in parallel (#30381)

Continuation of ethereum/go-ethereum#28546

core/types: more easily extensible tx signing (#30372)

This change makes the code slightly easier for downstream-projects to extend with more signer-types, but if functionalily equivalent to the previous code.

core, trie: prealloc capacity for maps (#30437)

• preallocate capacity for map
• avoid reinject adding empty value
• use maps.Copy

core/tracing: fix typo in comment (#30443)

minor fix

core/tracing: add verkle gas change reasons to changelog (#30444)

Add changes from #30409 and #29338 to changelog.

---

Co-authored-by: Martin HS [email protected]
Co-authored-by: Guillaume Ballet [email protected]

Revert "core/rawdb: remove unused transition status state accessors" (#30449)

Reverts ethereum/go-ethereum#30433

params: release go-ethereum v1.14.9 stable (#30455)