Use dev-dependencies and requires-dev for lockfile compatibility
#8501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
compatibility
zanieb
approved these changes
Oct 23, 2024
zanieb
added a commit
that referenced
this pull request
Oct 28, 2024
…8599) ## Summary Unfortunately, it looks like we lost #8501 somewhere in a bad rebase. This PR re-adds the change, with compatibility for those lockfiles created in v0.4.27. I'm not certain we should actually merge this. It might be less painful and confusing to just bite the bullet on the change. --------- Co-authored-by: Zanie Blue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per discussion on Discord, we're going to keep these names for now (changed in #8391 but not yet released) for compatibility. They're just cosmetic, but with the changes as-is, if you ran an older uv version over a newer lockfile...
uv sync: the lockfile would be invalidated, and we'd re-resolve.uv sync --frozen: we'd silently skip the development dependencies.We'll change these names in the future once we've added better error handling around lockfile versions (#8465).