Rename dev dependencies to dependency groups in lockfile #8391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
enhancement
charliermarsh
force-pushed
the
charlie/lock-dep-groups
branch
3 times, most recently
from
08317a1 to
189b040
Compare
Contributor
How is this about forward compatibility? i.e. user who has old uv wants to interact with new lockfile from random project? |
Merged
j178
reviewed
Oct 21, 2024
charliermarsh
force-pushed
the
tracking/735
branch
from
bb83978 to
c246fbf
Compare
charliermarsh
force-pushed
the
charlie/lock-dep-groups
branch
from
189b040 to
166f81a
Compare
Member
Author
Yeah this wouldn't work. I don't think bumping the version even helps here, because prior versions of uv don't look at it and don't (e.g.) throw an error or show a warning. |
zanieb
approved these changes
Oct 22, 2024
charliermarsh
added a commit
that referenced
this pull request
Oct 22, 2024
## Summary This is backwards compatible (we respect `dev-dependencies` as an alias). Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 23, 2024
## Summary This is backwards compatible (we respect `dev-dependencies` as an alias). Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 23, 2024
…8501) ## Summary Per discussion on Discord, we're going to keep these names for now (changed in #8391 but not yet released) for compatibility. They're just cosmetic, but with the changes as-is, if you ran an older uv version over a newer lockfile... - For `uv sync`: the lockfile would be invalidated, and we'd re-resolve. - For `uv sync --frozen`: we'd silently skip the development dependencies. We'll change these names in the future once we've added better error handling around lockfile versions (#8465).
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
This is backwards compatible (we respect `dev-dependencies` as an alias). Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
This is backwards compatible (we respect `dev-dependencies` as an alias). Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
This is backwards compatible (we respect `dev-dependencies` as an alias). Part of #8272.
zanieb
pushed a commit
that referenced
this pull request
Oct 25, 2024
This is backwards compatible (we respect `dev-dependencies` as an alias). Part of #8272.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is backwards compatible (we respect
dev-dependenciesas an alias).Part of #8272.