Update Selenium version to 4.23.0 #259
Conversation
mialeska
commented
Jul 29, 2024
mialeska
commented
- Add async methods to BrowserNavigation proxy
- Add async methods to BrowserNavigation proxy
WalkthroughThe recent updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BrowserNavigation
participant DevToolsAPI
User->>BrowserNavigation: GoToUrlAsync("http://example.com")
BrowserNavigation->>DevToolsAPI: Navigate to URL
DevToolsAPI-->>BrowserNavigation: URL Loaded
BrowserNavigation-->>User: Page displayed
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj (1 hunks)
- Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml (3 hunks)
- Aquality.Selenium/src/Aquality.Selenium/Browsers/BrowserNavigation.cs (5 hunks)
- Aquality.Selenium/src/Aquality.Selenium/Browsers/BrowserWindowNavigation.cs (1 hunks)
- Aquality.Selenium/src/Aquality.Selenium/Configurations/WebDriverSettings/FirefoxSettings.cs (1 hunks)
- Aquality.Selenium/src/Aquality.Selenium/Elements/Actions/MouseActions.cs (1 hunks)
- Aquality.Selenium/src/Aquality.Selenium/Elements/Element.cs (1 hunks)
- Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj (1 hunks)
- Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs (1 hunks)
- Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/Usecases/FileDownloadingTests.cs (1 hunks)
Files skipped from review due to trivial changes (5)
- Aquality.Selenium/src/Aquality.Selenium/Browsers/BrowserWindowNavigation.cs
- Aquality.Selenium/src/Aquality.Selenium/Elements/Actions/MouseActions.cs
- Aquality.Selenium/src/Aquality.Selenium/Elements/Element.cs
- Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj
- Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/Usecases/FileDownloadingTests.cs
Additional comments not posted (13)
Aquality.Selenium/src/Aquality.Selenium/Configurations/WebDriverSettings/FirefoxSettings.cs (1)
30-31: LGTM! But verify the usage of the updated property in the codebase.The changes align with the updated Selenium API or a refactoring of the FirefoxOptions class.
However, ensure that all references to
BrowserExecutableLocationare updated toBinaryLocationin the codebase.Verification successful
Verification successful.
The property
BrowserExecutableLocationhas been successfully updated toBinaryLocationacross the codebase.
FirefoxSettings.csYandexSettings.csOperaSettings.csScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `BrowserExecutableLocation` are updated to `BinaryLocation`. # Test: Search for the old property name. Expect: No occurrences of `BrowserExecutableLocation`. rg --type cs 'BrowserExecutableLocation'Length of output: 40
Script:
#!/bin/bash # Description: Verify all references to `BrowserExecutableLocation` are updated to `BinaryLocation`. # Test 1: Search for the old property name. Expect: No occurrences of `BrowserExecutableLocation`. rg --type cs 'BrowserExecutableLocation' # Test 2: Search for the new property name. Expect: Occurrences of `BinaryLocation`. rg --type cs 'BinaryLocation'Length of output: 1944
Aquality.Selenium/src/Aquality.Selenium/Browsers/BrowserNavigation.cs (4)
46-54: LGTM!The ForwardAsync method is correctly implemented, logging the action and invoking the asynchronous navigation function.
96-105: LGTM!The GoToUrlAsync(string) method is correctly implemented, logging the action and invoking the asynchronous navigation function.
107-116: LGTM!The GoToUrlAsync(Uri) method is correctly implemented, logging the action and invoking the asynchronous navigation function.
127-135: LGTM!The RefreshAsync method is correctly implemented, logging the action and invoking the asynchronous refresh function.
Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj (1)
89-89: LGTM! But verify compatibility with the updated package version.The version of the
Aquality.Selenium.Corepackage is updated from3.0.9to3.0.12.However, ensure that the project is compatible with the updated package version.
Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs (3)
62-62: Update DevTools API version.The instantiation of
SetDeviceMetricsOverrideCommandSettingshas been updated to use version 127 of the DevTools API.
64-64: Update DevTools API version.The instantiation of
DisplayFeaturehas been updated to use version 127 of the DevTools API.
66-66: Update DevTools API version.The
Orientationsetting has been updated to use version 127 of the DevTools API.Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml (4)
357-362: LGTM!The
ForwardAsyncmethod is well-documented and correctly added.
382-387: LGTM!The
GoToUrlAsync(System.Uri)method is well-documented and correctly added.
394-399: LGTM!The
RefreshAsyncmethod is well-documented and correctly added.
1493-1493: Typographical correction approved.The correction from "Perfroms" to "Performs" improves clarity.
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- Aquality.Selenium/src/Aquality.Selenium/Browsers/BrowserNavigation.cs (5 hunks)
- azure-pipelines.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- Aquality.Selenium/src/Aquality.Selenium/Browsers/BrowserNavigation.cs
Additional comments not posted (3)
azure-pipelines.yml (3)
18-23: Upgrade to SonarCloudPrepare@2 and addition of scannerMode parameter.The upgrade to version 2 and the addition of the
scannerModeparameter aligns the task with the MSBuild system, which is appropriate for .NET projects.
39-43: Upgrade to SonarCloudAnalyze@2 and addition of jdkversion parameter.The upgrade to version 2 and the addition of the
jdkversionparameter ensure compatibility with Java 17, which may be necessary for the project dependencies or to leverage specific features of Java 17.
45-48: Upgrade to SonarCloudPublish@2 and addition of pollingTimeoutSec parameter.The upgrade to version 2 and the addition of the
pollingTimeoutSecparameter allow for more robust handling of the publication process by controlling the timeout duration for polling the quality gate results.
