rename nightly 6 1 to nightly next #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To not have to rename threshold directories when the nightly branch changes. Modifications: Use nightly_next as swift version in the matrix generation script which is picked up by the benchmark script. Result: Benchmark thresholds will attempt to find directories named nightly_next, not nightly_6_1.
Lukasa
approved these changes
Mar 3, 2025
rnro
added a commit
to rnro/swift-nio
that referenced
this pull request
Mar 7, 2025
Following on from apple#3126 delete `Benchmarks/Thresholds/nightly-6.1` and `IntegrationTests/tests_04_performance/Thresholds/nightly-6.1.json` which is no longer needed now that the shared benchmarks workflow has been updated.
Lukasa
pushed a commit
that referenced
this pull request
Mar 7, 2025
Following on from #3126 delete `Benchmarks/Thresholds/nightly-6.1` and `IntegrationTests/tests_04_performance/Thresholds/nightly-6.1.json` which is no longer needed now that the shared benchmarks workflow has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nightly_next as swift version
see #3122
Motivation:
To not have to rename threshold directories when the nightly branch
changes.
Modifications:
is picked up by the benchmark script.
Result:
Benchmark thresholds will attempt to find directories named
nightly_next, not nightly_6_1.