Skip to content

Conversation

@reyryan
Copy link

@reyryan reyryan commented Jul 17, 2025

SUMMARY

This is a fix on the recent issue related to tooltip styling #33865.

fixes: #33865

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Create a chart (ie Pie Chart)
  2. Right-click on the chart
  3. Verify that the tooltip content has proper indentation

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/packages/superset-ui-core/src/utils/html.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@dosubot dosubot bot added the viz:charts:tooltip Related to tooltips in charts label Jul 17, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sadpandajoe sadpandajoe requested a review from msyavuz July 17, 2025 18:16
Comment on lines +28 to +29
tr: ['style', 'class'],
td: ['style', 'class'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two already exist, you just need to add 'class' few lines below

@sfirke
Copy link
Member

sfirke commented Jul 18, 2025

Is this still needed after #34018 ? Just checking as I know this bug got reported in many places.

@msyavuz
Copy link
Member

msyavuz commented Jul 18, 2025

@sfirke Oh, you are right. We already have the style implemented in another pr. Closing this one as the issue is fixed now in #34018.

@msyavuz msyavuz closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages size/XS viz:charts:tooltip Related to tooltips in charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Tooltip styles and whitespace missing after upgrade to 5.0.0 (likely due to XSS filter)

3 participants