fix: Update spacing on echart legends #34018
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/utils/html.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
|
@sadpandajoe Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@sadpandajoe Ephemeral environment spinning up at http://35.161.120.126:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/utils/html.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
sadpandajoe
requested review from
Vitor-Avila,
eschutho,
geido,
kasiazjc,
msyavuz and
yousoph
| table: ['width', 'border', 'align', 'valign', 'style'], | ||
| tr: ['rowspan', 'align', 'valign', 'style'], | ||
| td: ['width', 'rowspan', 'colspan', 'align', 'valign', 'style'], | ||
| th: ['width', 'rowspan', 'colspan', 'align', 'valign', 'style'], | ||
| tbody: ['align', 'valign', 'style'], | ||
| thead: ['align', 'valign', 'style'], | ||
| tfoot: ['align', 'valign', 'style'], |
There was a problem hiding this comment.
Not sure about allowing style tags here, can't we change the styles directly?
https://cheatsheetseries.owasp.org/cheatsheets/XSS_Filter_Evasion_Cheat_Sheet.html#style-attribute-that-breaks-up-an-expression
There was a problem hiding this comment.
I think we tried to add the styles here: https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/utils/tooltip.ts, but when we sanitized it, it then broke the spacing and formatting. If we think what we did with theming could change how we redo tooltips, we should probably implement it the correct way.
There was a problem hiding this comment.
Yeah, those styles do nothing. I don't think theming can change how we handle tooltips, maybe setting classname might be the better way to do this?
(cherry picked from commit cb6342f)
michael-s-molina
added
the
v5.0
5 participants
SUMMARY
The legend looks a bit more squished on master now than it was before with 4.X and 5.X. This PR will get it back to that size.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION