Rewrite APIJAR extractor to use Java 24 classfile API and kill ASM dependency also for build system #14613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendency also for build system
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
Contributor
Author
|
P.S.: The preview flag removal code is not used by vector API, but I ported it over, too. I tested it with temporarily extracting the Java 24 |
Contributor
Author
|
Output of regnerate is same as before: The resulting apijar file has similar size, but it is a bit larger. I did not find out what exactly the problem is. But also from my work on the expressions module I figured out that classfile API is a bit more verbose when building the constant pool (numbers are much larger,...). Maybe this is where it comes from. I compared the Eclipse CLASS file dumps in old and new JAR, they contains same symbols and constants, just with different indexes. |
Contributor
Author
|
I added an additional check missing previously as replacement for the last line in above output: All referenced classes left over after processing need to be publicly available in |
uschindler
force-pushed
the
dev/killAsmDependency
branch
from
dc1d6ed to
fd704fb
Compare
Contributor
Author
|
Thanks for review, I will merge now! |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
Member
|
this is awesome, thank you @uschindler |
weizijun
added a commit
to weizijun/lucene
that referenced
this pull request
May 7, 2025
* main: (27 commits) deps(java): bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 (apache#14621) Improve user-facing docs for geo package (apache#14534) Enabling histogram collection for PointRangeQuery (apache#14560) Move sloppySin into SloppyMath from GeoUtils (apache#14516) Rewrite APIJAR extractor to use Java 24 classfile API and kill ASM dependency also for build system (apache#14613) CHANGES entry for apache#14226 (optimistic KNN Query) OptimisticKnnVectorQuery (apache#14226) Fix for Windows (spaces in paths) apache#14608 Update jdk requirements in README to OpenJDK 24 (apache#14610) Always check gradle wrapper sha checksum and download if necessary (apache#14608) Fix changelog verifier (apache#14606) MultiRange query for SortedNumeric DocValues (apache#14404) Remove RANDOM_PRELOAD read advice, which is not actually used (apache#14593) Remove duplicate test (apache#14602) Refactor the expressions compiler to use official ClassData BSM with indexed lookup (apache#14602) Disallow EA versions to run Gradle (apache#14601) Add back-compat indices for 10.2.1 Add Lucene 10.2.1 version constant DOAP changes for release 10.2.1 Revert "An attempt to make jenkins pass with the currently installed jdk24-ea. To be reverted later. apache#14600" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewrite was not so easy but I got it working.... (in fact, the Javascript compiler was easier).
The code also adds some more sanity checks about correct Java versions. So it will complain in future when the APIJAR extractor extracts for a older java version than the compile target.