Skip to content

Fix changelog verifier #14606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

Fix changelog verifier #14606

merged 1 commit into from
May 3, 2025

Conversation

@stefanvodita
Copy link
Contributor

@stefanvodita stefanvodita commented May 3, 2025

I managed to find and fix a few issues:

  1. Some GitHub-provided variables seemed not to expand correctly (see lines 29,30 in the new version).
  2. We need to fetch deep to ensure the commits we diff are present.
  3. The diff should happen between the PR head and the merge base, not the main head. Otherwise the diff for a PR that is not rebased will contain unrelated changes.

Addresses #13898 #14190

This was referenced May 3, 2025
Closed
Closed
@stefanvodita stefanvodita merged commit 91cae19 into apache:main May 3, 2025
7 checks passed
weizijun added a commit to weizijun/lucene that referenced this pull request May 7, 2025
@weizijun
Merge branch 'main' into reduce-NeighborArray-memory
3cb42c6 
* main: (27 commits)
  deps(java): bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 (apache#14621)
  Improve user-facing docs for geo package (apache#14534)
  Enabling histogram collection for PointRangeQuery (apache#14560)
  Move sloppySin into SloppyMath from GeoUtils (apache#14516)
  Rewrite APIJAR extractor to use Java 24 classfile API and kill ASM dependency also for build system (apache#14613)
  CHANGES entry for apache#14226 (optimistic KNN Query)
  OptimisticKnnVectorQuery (apache#14226)
  Fix for Windows (spaces in paths) apache#14608
  Update jdk requirements in README to OpenJDK 24 (apache#14610)
  Always check gradle wrapper sha checksum and download if necessary (apache#14608)
  Fix changelog verifier (apache#14606)
  MultiRange query for SortedNumeric DocValues (apache#14404)
  Remove RANDOM_PRELOAD read advice, which is not actually used (apache#14593)
  Remove duplicate test (apache#14602)
  Refactor the expressions compiler to use official ClassData BSM with indexed lookup (apache#14602)
  Disallow EA versions to run Gradle (apache#14601)
  Add back-compat indices for 10.2.1
  Add Lucene 10.2.1 version constant
  DOAP changes for release 10.2.1
  Revert "An attempt to make jenkins pass with the currently installed jdk24-ea. To be reverted later. apache#14600"
  ...
@stefanvodita stefanvodita deleted the fix-verifier branch May 8, 2025 10:57
@stefanvodita stefanvodita mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stefanvodita