Improve coalesce kernel tests
#7626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 8, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_empty_schema() { |
Contributor
Author
There was a problem hiding this comment.
The point of this PR is to add direct coverage for coalesceing StringViewArrays rather than testing gc_string_view_array directly
That way I can change the internal implementation of coalesce and still maintain test coverage
alamb
commented
Jun 8, 2025
| .unwrap() | ||
| } | ||
|
|
||
| #[test] |
Contributor
Author
There was a problem hiding this comment.
These tests are all rewritten in terms of Test and coalsece
Dandandan
approved these changes
Jun 8, 2025
Contributor
Author
|
Thanks for the review @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
coalesceandconcatperformance for views… #7625 from @DandandanRationale for this change
I want to eventually remove
gc_string_viewbut currently the unit tests are in terms of that functionWhat changes are included in this PR?
Rewrite tests to be in terms of
coalesceinsteadAlso,
coalesceandconcatperformance for views (#7614)" #7623coalesceandconcatperformance for views… #7625 (comment)Codecov of this module is now 100%
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.