Revert "Revert "Improve coalesce and concat performance for views…
#7625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#7614)" (apache#7623)" This reverts commit da461c8.
Contributor
|
🤖 |
Contributor
|
🤖: Benchmark completed Details
|
Contributor
|
🤖 |
Contributor
|
🤖: Benchmark completed Details
|
Contributor
|
🤖 |
Contributor
|
🤖: Benchmark completed Details
|
Contributor
|
Love it -- looks great. Thank you @Dandandan |
alamb
approved these changes
Jun 8, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Dandandan -- this looks great to me
I am also working on writing some tests to add additional coverage. I hope to have that done later this morning
| if ideal_buffer_size == 0 { | ||
| // If the ideal buffer size is 0, all views are inlined | ||
| // so just reuse the views | ||
| return Arc::new(unsafe { |
Contributor
There was a problem hiding this comment.
I ran codecov and this is the only path that is not covered
cargo llvm-cov --html -p arrow-selectI think I can cover it with a sliced record batch. I will write some tests as a follow on PR to cover it
Contributor
|
I also made a follow on PR for adding some additional coverage here: |
alamb
added a commit
that referenced
this pull request
Jun 9, 2025
# Which issue does this PR close? - Follow on to #7625 from @Dandandan # Rationale for this change I want to eventually remove `gc_string_view` but currently the unit tests are in terms of that function # What changes are included in this PR? Rewrite tests to be in terms of `coalesce` instead Also, 1. Add additional coverage for the issue we saw in #7623 2. Add add coverage for the case where there are data buffers in the view, but they are not referenced by any view #7625 (comment) Codecov of this module is now 100% # Are there any user-facing changes? If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#7614)" (#7623)"
This reverts commit da461c8.
This adds a test and fix for the wrong index issue.
I also verified the change for DataFusion (and benchmarks show notable improvements).
Which issue does this PR close?
Closes #NNN.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?