Upgrade to object_store to 0.12.0
#7328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
added
the
next-major-release
|
Thank you @mbrobbel . BTW I am hoping we can get this PR ready and merged for a release next week. Specifically this one. |
8 tasks
|
Is this PR ready to go? Looks like
|
We could merge this and handle the conflict in #7252? |
That is my suggestion |
alamb
approved these changes
Mar 31, 2025
|
I think this is ready to be merged? I can put up a clean version of #7252 on top of this. |
alamb
changed the title
object_store to 0.12.0object_store to 0.12.0
Thanks @kylebarron -- this PR had a merge conflict so I merged up from main and resolved the issue. I'll plan to merge it when the tests are complete |
|
Thanks again @mbrobbel and @kylebarron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Bump
object_storeto the latest.What changes are included in this PR?
Handle breaking change (
Range<usize>->Range<u64>). An alternative would be to change theAsyncFileReadertrait to also useu64ranges, but I think converting makes more sense here.Edit: I just noticed #7238 and #7252. I can update this PR when that gets merged. Converting to draft for now.
Are there any user-facing changes?
Yes, this is a breaking change because the
ObjectStoretrait is part of the public API.