Skip to content

Conversation

@HaoranYi
Copy link

@HaoranYi HaoranYi commented Nov 1, 2025

Problem

If account's index map overgrows, we never shrink it even when later on the map become smaller.

image

Summary of Changes

Shrink the account's map when it is less than half used.

Fixes #

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (b210780) to head (a66bde8).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #8823     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         864      864             
  Lines      375150   375150             
=========================================
- Hits       312224   312203     -21     
- Misses      62926    62947     +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HaoranYi HaoranYi marked this pull request as ready for review November 4, 2025 16:10
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do this. IMO we shouldn't shrink because we'll likely need to grow shortly after, assuming that accounts keep being created. So we'd end up paying to move/reallocate.

I think when we have a properly memory limit for the in-mem index that we'll be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants