-
Couldn't load subscription status.
- Fork 23
Fix fields container animate key for Linux #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5c98e3f
WIP
PProfizi 2cffc4d
WIP
PProfizi 7ea0895
Fix error in deformation field for fields_container.py::animate
PProfizi 26b0f61
Fix error in deformation field for fields_container.py::animate
PProfizi 616a693
Update example due to fix
PProfizi 60ce382
Add key_event mapped to "a" to update the scene instead of closing.
PProfizi 9d5c404
Call animation() also when off_screen
PProfizi df2ac43
Take norm of multi_component fields
PProfizi 3bcb8bd
Fix flake8
PProfizi 9b79cab
Test the pv.OFFSCREEN value in cases of batch run
PProfizi f82afc3
Merge branch 'master' into fix/fields_container_animate_key
PProfizi d0603bb
Specify in the example that results must be transient
PProfizi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi that means that we set off_screen by defualt. Is that what we want ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anslpa I do not see how this sets
off_screen=Trueby default. This takes the value inkwargs, if not present then it is set toNone, and ifNonethen we do a last check of thepv.OFF_SCREENvariable which might have been set globally toTrue, for example when running tests or examples in our pipelines.I tested it and to me it is
Falseby default.