Fix fields container animate key for Linux #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 86.99% 87.94% +0.95%
==========================================
Files 68 68
Lines 7566 7582 +16
==========================================
+ Hits 6582 6668 +86
+ Misses 984 914 -70 |
anslpa
reviewed
Oct 26, 2022
| render_frame(0) | ||
| # If not off_screen, enable the user to choose the camera position | ||
| off_screen = kwargs.pop("off_screen", None) | ||
| if off_screen is None: |
There was a problem hiding this comment.
@PProfizi that means that we set off_screen by defualt. Is that what we want ?
There was a problem hiding this comment.
@anslpa I do not see how this sets off_screen=True by default. This takes the value in kwargs, if not present then it is set to None, and if None then we do a last check of the pv.OFF_SCREEN variable which might have been set globally to True, for example when running tests or examples in our pipelines.
I tested it and to me it is False by default.
cbellot000
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now one should press "a" to generate the animation, instead of "q", which quit the rendering window to create a new one, which did not work on Linux.