Skip to content

feature(md-icon-button): set fixed line height for wrapped content #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2016
Merged

feature(md-icon-button): set fixed line height for wrapped content #1469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e74cf8
feature(md-icon-button): set fixed line height for wrapped content
andrewmnlv Oct 11, 2016
0a8e9c5
feature(md-icon-button): set fixed line height for wrapped content
andrewmnlv Oct 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/button/_button-base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,6 @@ $md-mini-fab-padding: 8px !default;

i, md-icon {
padding: $padding 0;
line-height: $size - $padding * 2;
Copy link
Contributor

@tinayuangao tinayuangao Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change the $size or the $padding, the md-icon is no longer at the center.

Copy link
Contributor

@tinayuangao tinayuangao Oct 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "line-height: $md-icon-button-line-height;" could solve this issue.

Copy link
Contributor Author

@andrewmnlv andrewmnlv Oct 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinayuangao thank you
updated

}
}
1 change: 1 addition & 0 deletions src/lib/button/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
border-radius: $md-icon-button-border-radius;

.md-button-wrapper > * {
line-height: $md-icon-button-line-height;
vertical-align: middle;
}
}
Expand Down