feature(md-icon-button): set fixed line height for wrapped content #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<md-icon></md-icon> should be centered inside <button md-icon-button></button> when it's size is reduced in additional fix it for md-fab Closes angular#1426
googlebot
added
the
cla: yes
Member
|
@tinayuangao can you take a look at this? |
tinayuangao
reviewed
Oct 25, 2016
src/lib/button/_button-base.scss
Outdated
|
|
||
| i, md-icon { | ||
| padding: $padding 0; | ||
| line-height: $size - $padding * 2; |
Contributor
There was a problem hiding this comment.
If we change the $size or the $padding, the md-icon is no longer at the center.
Contributor
There was a problem hiding this comment.
Use "line-height: $md-icon-button-line-height;" could solve this issue.
<md-icon></md-icon> should be centered inside <button md-icon-button></button> when it's size is reduced in additional fix it for md-fab Closes angular#1426
Contributor
|
LGTM |
tinayuangao
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be centered inside when it's size is reduced
in additional fix it for md-fab
Closes #1426