-
Notifications
You must be signed in to change notification settings - Fork 4k
🚧 AGP 9 #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🚧 AGP 9 #1959
Changes from all commits
d46b9dc
9908869
a0ad925
fd939d5
80bee3d
ee84562
dbce15c
f1043ef
61d7a3b
fb4a5ca
df589f6
1ea5c39
ece169e
4312937
3bc6ed6
b060fd0
52b118a
1ebc99d
06fe669
1e7095d
354261e
e420d2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ object DataStoreModule { | |
|
|
||
| @Provides | ||
| @Singleton | ||
| internal fun providesUserPreferencesDataStore( | ||
| fun providesUserPreferencesDataStore( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this change needed? Is it related to the AGP upgrade?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, see this commit: fd939d5 |
||
| @ApplicationContext context: Context, | ||
| @Dispatcher(IO) ioDispatcher: CoroutineDispatcher, | ||
| @ApplicationScope scope: CoroutineScope, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,3 +63,5 @@ roborazzi.test.verify=true | |
| # Prevent uninstall app after instrumented tests | ||
| # https://issuetracker.google.com/issues/295039976 | ||
| android.injected.androidTest.leaveApksInstalledAfterRun=true | ||
|
|
||
| android.newDsl=false | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a comment on why we need to opt out linking to the hilt bug.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not meant to be merged as-is, as mentioned in the PR first message. |
||
Uh oh!
There was an error while loading. Please reload this page.