-
Notifications
You must be signed in to change notification settings - Fork 4k
🚧 AGP 9 #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🚧 AGP 9 #1959
Conversation
d2767d1 to
a19fcd9
Compare
`error: cannot find symbol` on: - `DataStoreModule.INSTANCE.providesUserPreferencesDataStore$datastore_demoDebug` - `SyncModule.Companion.provideFirebaseMessaging$work_prodDebug()`
They must have been removed as they are no longer resolved by default.
Updated Android Gradle Plugin and Tools versions.
(included in firebase-bom 34.5.0)
Can you point me to how to repro this? |
|
I've not been able to reproduce it on my other projects, but on this one, simply build a |
not sure if they were dropped on purpose...
101662a to
cf6e7dd
Compare
…buildTypes leading to "debuggable" release builds.
|
I found the issue, fixed in 52b118a. I've refactored the code to configure only the |
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/AndroidCompose.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaFlavor.kt
Outdated
Show resolved
Hide resolved
| @Provides | ||
| @Singleton | ||
| internal fun providesUserPreferencesDataStore( | ||
| fun providesUserPreferencesDataStore( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed? Is it related to the AGP upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see this commit: fd939d5
| # https://issuetracker.google.com/issues/295039976 | ||
| android.injected.androidTest.leaveApksInstalledAfterRun=true | ||
|
|
||
| android.newDsl=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment on why we need to opt out linking to the hilt bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not meant to be merged as-is, as mentioned in the PR first message.
That being said, if you really want to merge this PR before alls bugs are fixed & workarounds are removed, I can add a comment for this. Let me know.
sync/work/src/demo/kotlin/com/google/samples/apps/nowinandroid/sync/di/SyncModule.kt
Outdated
Show resolved
Hide resolved
sync/work/src/prod/kotlin/com/google/samples/apps/nowinandroid/sync/di/SyncModule.kt
Outdated
Show resolved
Hide resolved
Add comment to clarify Jacoco configuration for debug builds.
… changes as requested
This neat website can be used to track the current issues with AGP 9: https://agp-status.frybits.com/agp-9.0.0/
fixed in KSP 2.2.20-2.0.3
Temporary workaround with
android.newDsl=falseTemporary workaround with
android.newDsl=falsereleasebuild type hasisDebuggableforced to true, even when explicitly turned off.