[Streams] Fix null exceptions being propagated on downstream completion #7497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Feb 6, 2025
Comment on lines
+1303
to
+1306
| // Some stages might propagate null exceptions due to improper Task continuation handling | ||
| // (see https://github.com/akkadotnet/Akka.Persistence.Sql/issues/498) | ||
| // This is a stop gap solution to make sure that Akka.Streams doesn't behave improperly | ||
| // until we can fix all of those |
There was a problem hiding this comment.
Document the reason in the code for future developers
Aaronontheweb
approved these changes
Feb 6, 2025
Comment on lines
+1303
to
+1306
| // Some stages might propagate null exceptions due to improper Task continuation handling | ||
| // (see https://github.com/akkadotnet/Akka.Persistence.Sql/issues/498) | ||
| // This is a stop gap solution to make sure that Akka.Streams doesn't behave improperly | ||
| // until we can fix all of those |
|
Well the code looks good in spirit sans the compilation error :p |
|
It should be fixed now |
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Mar 12, 2025
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes akkadotnet/Akka.Persistence.Sql#498
Changes
Replace null
Exceptionwith an empty exception to prevent stages from dying from improper task continuation handling.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):