Skip to content

Conversation

@jespercockx
Copy link
Member

This PR makes the necessary changes to add the three new constructors of the Sort datatype in the reflected syntax which are added to Agda itself in agda/agda#5289.

@jespercockx
Copy link
Member Author

Travis is failing, but I don't see why:

$ agda $AGDA_OPTIONS $RTS_OPTIONS -i . -i src/ --html safe.agda

Checking safe (/home/travis/build/agda/agda-stdlib/safe.agda).

/home/travis/build/agda/agda-stdlib/safe.agda:544,1-19

Importing module Debug.Trace using the --rewriting flag from a

module which does not.

when scope checking the declaration

  import Debug.Trace

The command "agda $AGDA_OPTIONS $RTS_OPTIONS -i . -i src/ --html safe.agda" exited with 42.

This seems to be related to the relatively recent change that made --rewriting infective, but I do not see how the changes in this PR have any influence on that.

@gallais
Copy link
Member

gallais commented Mar 28, 2021

This seems to be related to the relatively recent change that made --rewriting infective, but I do not see how the changes in this PR have any influence on that.

Could be we were using a commit prior to that change. When you bumped the commit
to the one corresponding to your PR you also included all of the changes that
happened in between.

@gallais gallais self-assigned this Mar 28, 2021
@jespercockx
Copy link
Member Author

Great, thanks for fixing it! Anything else that still needs to happen before this can be merged? If not I'd like to merge it soon so the main PR for Agda itself can also be merged.

@gallais
Copy link
Member

gallais commented Mar 28, 2021

I think it's good to go.

@MatthewDaggitt MatthewDaggitt added the upstream Changes induced by Agda upstream label Mar 29, 2021
@MatthewDaggitt MatthewDaggitt added this to the agda-v2.6.2 milestone Mar 29, 2021
@MatthewDaggitt MatthewDaggitt merged commit 04569b5 into agda:experimental Mar 29, 2021
@MatthewDaggitt MatthewDaggitt modified the milestones: agda-v2.6.2, v1.7 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reflection upstream Changes induced by Agda upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants