Skip to content

More theme fixes #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

Conversation

Samir-Rashid
Copy link
Contributor

@Samir-Rashid Samir-Rashid commented Apr 20, 2025

This PR contains a series of a few independent fixes.

  1. 3d308f4 I found one more css bug in the dark theme, relating to how <figcaption>s are shown
  2. 0e160dc Fixes default theme should match user preference #2953. By default, the website will respect the dark or light mode preference expressed by the user's browser. The preference can still be overridden by the toggle button. I tested this by deleting the stored value in browser Local Storage, and the theme now follows the light/dark mode of your browser (no toggle clicking needed).
  3. 259ee5a the new autoscroll dep had two bugs: it didn't have enough padding for the masthead, and it also did not update the URL when you click on a link like #scroll-to-id. These problems are now fixed, making it easier to share sections of webpages.
  4. 1de3d66 Fixed image carousel popup for image links and added image expanding popup for normal images.

@rjzupkoii
Copy link
Collaborator

Excellent work, thanks for the updates to the theme!

@rjzupkoii rjzupkoii merged commit 71ad192 into academicpages:master Apr 21, 2025
Arghyadatta pushed a commit to Arghyadatta/arghyadatta.github.io that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default theme should match user preference
2 participants