Skip to content

Conversation

@connorjchen
Copy link
Collaborator

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

connorjchen and others added 10 commits December 1, 2022 14:37
* refactor: Make request_impl into a private function (#478)

* Made request_impl into a private method

* refactor: Alias function for safe_sign_transaction called sign (#470)

* Create alias for safe_sign_transaction

* Update tests to use new submit-transaction alias

* fix: fix Github Actions issues (#485)

* add better debugging

* fix yaml

* switch to ubuntu 20.04

* switch back to latest

* Revert "switch back to latest"

This reverts commit 564002b.

* clean up

* add 3.11 support

Co-authored-by: Mayukha Vadari <[email protected]>
* Refactored wallet class and tests

* Fix leading zero for key formatting

* Changed from_entropy to take in hex string

* Update core keypairs docs

* Throw error instead truncate for generate seed with entropy

* Refactor test main wallet generation suite
* Added from secret numbers method and tests

Co-authored-by: Jackson Mills <[email protected]>
@connorjchen connorjchen changed the title [DO NOT MERGE] Draft PR for xrpl-py2.0.0beta [DO NOT MERGE] Draft PR for xrpl-py2.0.0beta to see tests Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants