Skip to content

Conversation

@connorjchen
Copy link
Collaborator

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

connorjchen and others added 3 commits November 28, 2022 16:40
* Made request_impl into a private method
* Create alias for safe_sign_transaction

* Update tests to use new submit-transaction alias
* add better debugging

* fix yaml

* switch to ubuntu 20.04

* switch back to latest

* Revert "switch back to latest"

This reverts commit 564002b.

* clean up

* add 3.11 support
@connorjchen connorjchen marked this pull request as ready for review December 1, 2022 19:37
@connorjchen connorjchen merged commit 4f0776e into xrpl-py-2.0 Dec 1, 2022
JST5000 pushed a commit that referenced this pull request Jun 28, 2023
* refactor: Make request_impl into a private function (#478)

* Made request_impl into a private method

* refactor: Alias function for safe_sign_transaction called sign (#470)

* Create alias for safe_sign_transaction

* Update tests to use new submit-transaction alias

* fix: fix Github Actions issues (#485)

* add better debugging

* fix yaml

* switch to ubuntu 20.04

* switch back to latest

* Revert "switch back to latest"

This reverts commit 564002b.

* clean up

* add 3.11 support

Co-authored-by: Mayukha Vadari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants