Skip to content

add tigerhelpers #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add tigerhelpers #126

wants to merge 3 commits into from

Conversation

@Ishan1522
Copy link
Member

@Ishan1522 Ishan1522 commented Mar 4, 2025 •
edited
Loading

@Ishan1522 Ishan1522 added bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on low priority low priority task backlog item currently on the backlog of stuff to do wishful thinking this issue is wishful thinking do not merge (yet) this is a joke this issue is a joke, dw about it labels Mar 4, 2025
@Ishan1522 Ishan1522 linked an issue Mar 4, 2025 that may be closed by this pull request
Update to TigerHelpers v1.1.0 vendor dep and nuke MegaTagPoseEstimate #121
Open
@JacksonElia
Copy link
Member

wait u forgot some labels

@JacksonElia JacksonElia added documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested needs robot for testing regular priority normal priority item high priority extremely important stuff that NEEDS to get done sim testing Should be tested using simulation as a first step this is not a joke minion task labels Mar 4, 2025
JacksonElia
JacksonElia reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we made PoseEstimate a record so it works nicer with akit. Where/how do we log the PoseEstimates?

src/main/java/frc/robot/subsystems/vision/PhysicalVision.java
@Override
public double getAmbiguity(Limelight limelight) {
return limelightEstimates.get(limelight.getId()).ambiguity;
return limelightEstimates.get(limelight.getId()).rawFiducials()[getNumberOfAprilTags(limelight)].ambiguity();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhh I'll add some methods for ambiguity to PoseEstimate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I think you need to add a - 1 here so theres no overflow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuh uh

@Ishan1522
Copy link
Member Author

stfu

@JacksonElia
Copy link
Member

I hope ur laptop explodes

@JacksonElia
Copy link
Member

yooo merge tss

@Ishan1522
Copy link
Member Author

this shit dumb af

@Ishan1522
Copy link
Member Author

tiger helpers stupid af

@JacksonElia JacksonElia mentioned this pull request Oct 5, 2025
Open
@Ishan1522
Copy link
Member Author

Ishan1522 commented Oct 5, 2025 •
edited
Loading

Ok I just looked at it and the only thing that needs to be done is make it consistent with main, fix the overflow thingy (ez pz), and do some basic testing to make sure it runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacksonElia JacksonElia JacksonElia left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backlog item currently on the backlog of stuff to do bug Something isn't working do not merge (yet) documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed high priority extremely important stuff that NEEDS to get done invalid This doesn't seem right low priority low priority task minion task needs robot for testing offseason idea question Further information is requested regular priority normal priority item sim testing Should be tested using simulation as a first step this is a joke this issue is a joke, dw about it this is not a joke wishful thinking this issue is wishful thinking wontfix This will not be worked on

Projects

No open projects
Reefscape project
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to TigerHelpers v1.1.0 vendor dep and nuke MegaTagPoseEstimate

3 participants

@Ishan1522 @JacksonElia