Skip to content

✨ ENH: Add Neighbourhood Querying Support To AnnotationStore #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
May 4, 2023
Merged

✨ ENH: Add Neighbourhood Querying Support To AnnotationStore #540

Show file tree
Hide file tree
Changes from 74 commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
7bbfece
ENH: More Helpful __repr__ For Annotation
John-P Feb 16, 2023
168254a
WIP: Add Signature & Docstring For `nquery`
John-P Feb 16, 2023
a242d88
Merge branch 'develop' into feature-neighbourhood-query
shaneahmed Feb 16, 2023
9571d97
DOC: Reformat Docstring Examples Output
John-P Feb 16, 2023
1894adf
DOC: Update Docstring Examples
John-P Feb 17, 2023
eea3c4a
DOC: Update Docstring Examples
John-P Feb 17, 2023
00167df
DOC: Format Docstrings
John-P Feb 17, 2023
de53aab
Merge branch 'develop' into feature-neighbourhood-query
John-P Feb 17, 2023
7a9af8e
DOC: Update Docstring
John-P Feb 22, 2023
3206454
WIP: Add Naive nquery Implementation & Test
John-P Feb 22, 2023
80bcdac
WIP: Add Test For Empty Results and Add Fix
John-P Feb 22, 2023
43c4d70
DOC: Minor Docstring Edit
John-P Feb 22, 2023
97b4150
TST: Add nquery Test
John-P Feb 23, 2023
290219c
Merge branch 'develop' into feature-neighbourhood-query
shaneahmed Mar 2, 2023
a61bb42
ENH: Get Query Centroid From Bounds
John-P Feb 24, 2023
848c28d
ENH: Add nquery geometry_predicate Arg
John-P Feb 24, 2023
0eb4cce
DOC: Minor Typo Fix & Black Format
John-P Mar 3, 2023
c600240
MAINT: Add FIXME To Issue That Needs Addressing
John-P Mar 9, 2023
12090e3
MAINT: Add bbox_intersction Support To Base Class
John-P Mar 10, 2023
eb6c420
TST: Add DSL Test
John-P Mar 10, 2023
e05661d
MAINT: Change `use_centroid` Arg To `mode`
John-P Mar 10, 2023
e93c7a2
DOC: Remove FIXME Comment
John-P Mar 10, 2023
532583f
BUG: Fix From Poly Case In nquery
John-P Mar 10, 2023
a456c91
ENH: Query Geom. Pred. Bounds Centre Within Bounds
John-P Mar 10, 2023
47ea4cd
MAINT: Rename bbox_centroid_within to bbox_centre_within
John-P Mar 10, 2023
ad43dab
MAINT: Change box-box Distance From Buffer To Scaling
John-P Mar 10, 2023
0e659a0
TST: Add Grid Test For box-box and boxpoint-boxpoint
John-P Mar 10, 2023
54bfb8d
DOC: Remove Unimplemented Mode From Docstring
John-P Mar 10, 2023
d908303
MAINT: Remove Unimplemented Arg
John-P Mar 10, 2023
e8b2310
MAINT: Remove Unused Var + Validate Args
John-P Mar 10, 2023
a435c03
DOC: Document When geometry_predicate Ignored
John-P Mar 10, 2023
096b462
TST: Move Linter Excception In Tests
John-P Mar 10, 2023
2601eec
TST: Add Tests For Arg Validation
John-P Mar 10, 2023
f056245
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 10, 2023
666d42b
TST: Fix Very Large Grid Size In Test
John-P Mar 10, 2023
2191185
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 10, 2023
8bd7948
MAINT: Remove Unreachable Exception
John-P Mar 11, 2023
1dd22de
TST: Add Annotation Repr Test
John-P Mar 11, 2023
2d5cb36
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 11, 2023
c546161
DOC: Add Docstring Diagrams
John-P Mar 11, 2023
f5d8545
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 11, 2023
b6b3888
DOC: Update Docstring Text
John-P Mar 11, 2023
b6f2a51
TST: Rename Tests
John-P Mar 11, 2023
0f28333
TST: Add poly-poly Test
John-P Mar 11, 2023
ceaa356
DOC: Update Docstring Wording
John-P Mar 12, 2023
08954fe
DOC: Update Diagram
John-P Mar 12, 2023
39e05b4
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 14, 2023
9483e95
:rotating_light: Cov Pragma For Unreachable Branch
John-P Mar 14, 2023
b95fff1
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 16, 2023
d859e41
✅ Add Missing @staticmethod
John-P Mar 16, 2023
8637c7e
📝 Add Benchmarking Script For nquery
John-P Mar 17, 2023
0ad6114
📝 Add Docstrings
John-P Mar 17, 2023
3474a53
🎨 Change Asserts To Exceptions
John-P Mar 17, 2023
ef48ade
DOC: Minor Docstring Edits
John-P Mar 17, 2023
c250d41
📝 Fromat Docstring & Update Type Hints
John-P Mar 20, 2023
8168ccd
📝 Add Test Docstrings
John-P Mar 20, 2023
5f2db3e
♻️ Convert Benchmark Script To Notebook
John-P Mar 21, 2023
ed1de6a
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 21, 2023
80a59a7
📝 Convert Notebook Diagram To SVG
John-P Mar 21, 2023
cf20a45
♻️ Move SVG To Separate File For Compatibility
John-P Mar 21, 2023
6fa0606
📝 Fix SVG Scaling
John-P Mar 21, 2023
e85ce56
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 24, 2023
ccf8305
📝 Add Test Docstring
John-P Mar 24, 2023
1285640
✏️ Minor Typo Fix
John-P Mar 24, 2023
10f7775
📝 Fix Bug In Docstring Example
John-P Mar 24, 2023
31270db
✏️ Minor Typo Fix
John-P Mar 24, 2023
f141450
📝 Rephrase Docstring
John-P Mar 24, 2023
379282f
✏️ Minor Typo Fix
John-P Mar 24, 2023
b88d80e
📝 Rewording
John-P Mar 24, 2023
8bf9865
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 24, 2023
81472a6
Merge branch 'develop' into feature-neighbourhood-query
John-P Mar 31, 2023
8da3f0a
:memo: Fix missing eol
shaneahmed Apr 10, 2023
017194e
Merge branch 'develop' into feature-neighbourhood-query
shaneahmed Apr 10, 2023
b1ff20a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 10, 2023
520e417
🐛 Store cx, cy and area as floats
John-P Apr 28, 2023
151e6a6
🐛 Fix boxpoint-boxpoint Logic
John-P May 3, 2023
1ac580b
🔀 Merge branch 'develop' into feature-neighbourhood-query
John-P May 3, 2023
0c9f6f3
🐛 Change k To Distance on iquery()
John-P May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
591 changes: 591 additions & 0 deletions benchmarks/annotation_nquery.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

59 changes: 59 additions & 0 deletions benchmarks/nquery-concept.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/nquery-box-box.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/nquery-boxpoint-boxpoint.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/nquery-poly-poly.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading