Skip to content

DOC: Improve 07-advanced-modeling.ipynb #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 2, 2022
Merged

DOC: Improve 07-advanced-modeling.ipynb #439

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a0cc3ba
DOC: Edit metadata to make all cells visible to rtd.
DavidBAEpstein Jul 27, 2022
6c3171a
MAINT: edut raw source of list for jnb-rtd consistency.
DavidBAEpstein Jul 27, 2022
fa36aa8
MAINT: Remove redundant initial ">" and incorrect double quotes. Then…
DavidBAEpstein Jul 27, 2022
cf1ec10
MAINT: chage "temp" to "tmp"
DavidBAEpstein Jul 27, 2022
e261d15
MAINT: change "tail --lines 1" to "tail -n 1". Change wording around …
DavidBAEpstein Jul 27, 2022
fcf4971
MAINT: correct typo
DavidBAEpstein Aug 3, 2022
40f8a6f
BUG: Remove pretence that ON_GPU=False is viable/meaningful with current
DavidBAEpstein Aug 4, 2022
7333906
MAINT: Run Colab with GPU and make requisite changes.
DavidBAEpstein Aug 5, 2022
7ba0ba7
MAINT: Change number of WORKERS to 4. Add comment that the notebook c…
DavidBAEpstein Aug 5, 2022
17b2ae2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 5, 2022
9fa7a5d
Merge branch 'develop' into doc-07
shaneahmed Aug 15, 2022
14a7acd
Merge branch 'develop' into doc-07
shaneahmed Aug 17, 2022
ef81eb3
Merge branch 'develop' into doc-07
shaneahmed Aug 23, 2022
b828293
MAINT: Change "tail --lines 1" to "tail -n 1"
DavidBAEpstein Aug 25, 2022
a553452
DEV: Merge develop into `doc-07`.
shaneahmed Aug 25, 2022
9b950c9
Merge branch 'develop' into doc-07
shaneahmed Aug 26, 2022
58e6c93
MAINT: fix minor typo
DavidBAEpstein Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/07-advanced-modeling.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
},
"outputs": [],
"source": [
"!apt-get -y install libopenjp2-7-dev libopenjp2-tools openslide-tools | tail --line 1\n",
"!pip install tiatoolbox | tail --line 1\n",
"!apt-get -y install libopenjp2-7-dev libopenjp2-tools openslide-tools | tail -n 1\n",
"!pip install tiatoolbox | tail -n 1\n",
"\n",
"print(\"Installation is done.\")"
]
Expand All @@ -94,11 +94,11 @@
},
{
"cell_type": "code",
"execution_count": 1,
"execution_count": 2,
"metadata": {},
"outputs": [],
"source": [
"ON_GPU = True # Set `ON_GPU=True` if cuda-enabled GPU is availabe,\n",
"ON_GPU = True # Set `ON_GPU` ti `True` if cuda-enabled GPU is available,\n",
Copy link
Member

@shaneahmed shaneahmed Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ON_GPU to True?

Copy link
Collaborator Author

@DavidBAEpstein DavidBAEpstein Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the notebook crashes without GPU, I rewrote this saying that ON_GPU = False is not allowed. Some other notebooks have been written so that they still run successfully, though slowly, without GPU. But that is not the case here.

" # and otherwise to `False`."
]
},
Expand Down