-
Notifications
You must be signed in to change notification settings - Fork 101
DOC: Improve 07-advanced-modeling.ipynb #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… edit for clarity.
software packages.
1. Modify instruction about restarting runtime. Recommend using "Run all" twice. 2. Set ON_GPU = True and improve comment about this. 3. Define WORKERS as 0 or 1 depending on value of ON_GPU---an attempt to get a version without GPU working. 4. Improve clean up after run (in fact at the start of the next run) by putting all files downloaded or created into a single tmp directory. This makes clean up bullet proof against, for example, user interruption of execution at a random time.
…rashes if run without Cuda-enabled GPU.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## develop #439 +/- ##
========================================
Coverage 98.59% 98.59%
========================================
Files 58 58
Lines 5784 5784
Branches 1047 1047
========================================
Hits 5703 5703
Misses 69 69
Partials 12 12 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
examples/07-advanced-modeling.ipynb
Outdated
| "outputs": [], | ||
| "source": [ | ||
| "ON_GPU = True # Set `ON_GPU=True` if cuda-enabled GPU is availabe,\n", | ||
| "ON_GPU = True # Set `ON_GPU` ti `True` if cuda-enabled GPU is available,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ON_GPU to True?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the notebook crashes without GPU, I rewrote this saying that ON_GPU = False is not allowed. Some other notebooks have been written so that they still run successfully, though slowly, without GPU. But that is not the case here.
- Merge develop into `doc-07`.
|
I have checked the rendering of this jupyter notebook against the rendering provided by readthedocs. These two renderings are as similar as it is reasonable to require. The PR has been in a reasonable state for approval for some time, and I think it should now be approved by the reviewers. |
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DavidBAEpstein
Uh oh!
There was an error while loading. Please reload this page.