Upcast sum aggregation results to prevent overflows #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
commented
Sep 18, 2025
| return py::cast(*((float*)agg_buf)); | ||
| case TILEDB_FLOAT64: | ||
| return py::cast(*((double*)agg_buf)); | ||
| case TILEDB_INT8: |
There was a problem hiding this comment.
Based on the research I did, I have every reason to believe that this is the cause of the random segmentation faults we sometimes encounter during our daily test runs. For sum operations, the sum aggregation should return specific upcasted types source
ihnorton
reviewed
Sep 18, 2025
ihnorton
approved these changes
Sep 18, 2025
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes overflow issues in sum aggregations by upcasting results to wider types (
int8/int16/int32→int64,uint8/uint16/uint32→uint64,float→double). The results are returned correctly by the Core APIs, but at the pybind11 layer of TileDB-Py they were being cast to types that could not hold them. This PR also adds corner-case tests with extreme values to prevent regressions and ensure mathematically correct results.Closes CORE-376