-
Notifications
You must be signed in to change notification settings - Fork 36
Re-enable libtiledb grafting with auditwheel #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kounelisagis @ihnorton could you take a look on the |
The changeset here should only be applied when we are doing a CI build: https://github.com/TileDB-Inc/TileDB-Py/pull/2238/files#diff-64e075a38340d9989b5b947d543f08464f279b09f838b898dc5bf5a887b64603L46-R51 Otherwise when building from the sdist, the resulting (locally-built) wheel will only have the hardcoded |
56d918a to
d988169
Compare
a24707b to
24d97b5
Compare
39a3d82 to
da25222
Compare
b84c3f4 to
25f7b22
Compare
25f7b22 to
6bcc513
Compare
27a20e8 to
d586862
Compare
jp-dark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@ihnorton @kounelisagis Would you like to make a final check before we merge? |
|
I did a quick pass. The changes seem reasonable but, please, give me 1 more day. |
kounelisagis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing locally on macos and ubuntu, it all LGTM. Thanks!!!
This PR:
libtiledbcore library on an external destination and outside the wheel. This allowsauditwheelto pick it up as an external dependency and graft it.test_sdiststep as it fails. This requires further investigation as the built wheels have been installed on local/machines and EC2 instances and the tests run successfully during the build stage. https://github.com/TileDB-Inc/TileDB-Py/actions/runs/17504381704/job/49724678086#step:4:6929So the libtitledb library is being grafted with a
37432e17hash.REMARKS:
cibuildwheel -> auditwheelor building the wheel through the source distribution files.Closes CORE-332