Fixing sdist local build

Author: ktsitsi

.github/workflows/build-wheels.yml

@@ -122,13 +122,6 @@ jobs:
             name: sdist
             path: dist
 
-        - name: Examinate sdist artifact
-          shell: bash
-          run: |
-            gunzip dist/${{ needs.build_sdist.outputs.sdist_name }}
-            tar -xvf dist/*.tar
-            ls -la dist/tiledb/
-
         - name: Install sdist artifact
           run: pip install --verbose dist/${{ needs.build_sdist.outputs.sdist_name }}
 

tiledb/CMakeLists.txt

@@ -43,49 +43,61 @@ endif()
 
 install(TARGETS main DESTINATION tiledb)
 
+# Handle TileDB shared library installation and RPATH setup
 if(TILEDB_DOWNLOADED)
-
     if(DEFINED ENV{RUNNER_TEMP})
-        # For CI builds
+        # For CI builds - install to external directory
         set(TILEDB_EXTERNAL_DIR "$ENV{RUNNER_TEMP}/tiledb-external")
-        message(STATUS "Installing TileDB to: ${TILEDB_EXTERNAL_DIR}")
+        message(STATUS "CI Build - installing TileDB to: ${TILEDB_EXTERNAL_DIR}")
         install(IMPORTED_RUNTIME_ARTIFACTS TileDB::tiledb_shared 
                 DESTINATION "${TILEDB_EXTERNAL_DIR}")
 
-        # Set RPATH to use @rpath for proper library isolation on macOS
+        # Set RPATH for CI builds
         if(APPLE)
             set_target_properties(main PROPERTIES 
                 INSTALL_RPATH "@rpath"
                 BUILD_WITH_INSTALL_RPATH TRUE
             )
         else()
-            set_target_properties(main PROPERTIES INSTALL_RPATH "${TILEDB_EXTERNAL_DIR}")
+            set_target_properties(main PROPERTIES 
+                INSTALL_RPATH "${TILEDB_EXTERNAL_DIR}"
+                BUILD_WITH_INSTALL_RPATH TRUE
+            )
         endif()
     else()
-        # For local builds - auditwheel is not present
+        # For local builds - install to tiledb directory
+        message(STATUS "Local Build - installing TileDB shared library to tiledb directory")
         install(IMPORTED_RUNTIME_ARTIFACTS TileDB::tiledb_shared DESTINATION tiledb)
 
-        if (APPLE)
-            set_target_properties(main PROPERTIES INSTALL_RPATH "@loader_path")
+        # Set RPATH for local builds
+        if(APPLE)
+            set_target_properties(main PROPERTIES 
+                INSTALL_RPATH "@loader_path"
+                BUILD_WITH_INSTALL_RPATH TRUE
+            )
         elseif(UNIX)
-            set_target_properties(main PROPERTIES INSTALL_RPATH "\$ORIGIN")
+            set_target_properties(main PROPERTIES 
+                INSTALL_RPATH "\$ORIGIN"
+                BUILD_WITH_INSTALL_RPATH TRUE
+            )
         endif()
     endif()
-
-
 else()
-    # If using external TileDB core library force it to be linked at runtime using RPATH
+    # For external TileDB installations - no installation needed, just set RPATH
     get_property(TILEDB_LOCATION TARGET TileDB::tiledb_shared PROPERTY LOCATION)
     get_filename_component(TILEDB_LOCATION ${TILEDB_LOCATION} DIRECTORY)
-    message(STATUS "Setting RPATH for targets \"main\" and \"libtiledb\" to ${TILEDB_LOCATION}")
+    message(STATUS "External TileDB - setting RPATH to: ${TILEDB_LOCATION}")
 
     if(APPLE)
         set_target_properties(main PROPERTIES 
             INSTALL_RPATH "@rpath"
             BUILD_WITH_INSTALL_RPATH TRUE
         )
     else()
-        set_target_properties(main PROPERTIES INSTALL_RPATH ${TILEDB_LOCATION})
+        set_target_properties(main PROPERTIES 
+            INSTALL_RPATH ${TILEDB_LOCATION}
+            BUILD_WITH_INSTALL_RPATH TRUE
+        )
     endif()
 endif()
 

tiledb/libtiledb/CMakeLists.txt

@@ -59,18 +59,26 @@ endif()
 
 install(TARGETS libtiledb DESTINATION tiledb)
 
-if(NOT TILEDB_DOWNLOADED)    
-    # If using external TileDB core library force it to be linked at runtime using RPATH
+# Set RPATH for proper library resolution at runtime
+if(APPLE)
+    message(STATUS "Setting RPATH for target \"libtiledb\" to @loader_path")
+    set_target_properties(libtiledb PROPERTIES 
+        INSTALL_RPATH "@loader_path"
+        BUILD_WITH_INSTALL_RPATH TRUE
+    )
+elseif(UNIX)
+    message(STATUS "Setting RPATH for target \"libtiledb\" to \$ORIGIN")
+    set_target_properties(libtiledb PROPERTIES 
+        INSTALL_RPATH "\$ORIGIN"
+        BUILD_WITH_INSTALL_RPATH TRUE
+    )
+else()
+    # For Windows or other platforms, use absolute path
     get_property(TILEDB_LOCATION TARGET TileDB::tiledb_shared PROPERTY LOCATION)
     get_filename_component(TILEDB_LOCATION ${TILEDB_LOCATION} DIRECTORY)
     message(STATUS "Setting RPATH for target \"libtiledb\" to ${TILEDB_LOCATION}")
-    
-    if(APPLE)
-        set_target_properties(libtiledb PROPERTIES 
-            INSTALL_RPATH "@rpath"
-            BUILD_WITH_INSTALL_RPATH TRUE
-        )
-    else()
-        set_target_properties(libtiledb PROPERTIES INSTALL_RPATH ${TILEDB_LOCATION})
-    endif()
+    set_target_properties(libtiledb PROPERTIES 
+        INSTALL_RPATH ${TILEDB_LOCATION}
+        BUILD_WITH_INSTALL_RPATH TRUE
+    )
 endif()