Skip to content

Conversation

@cognifloyd
Copy link
Member

This adds an image.tag value for each of the pods.

Partially implements #132 (this only adds custom image.tag, not image.repository).

  • add image.tag overrides for all deployments
  • add image.tag overrides for all jobs

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Jun 18, 2021
@cognifloyd cognifloyd requested a review from arm4b June 18, 2021 20:19
@cognifloyd cognifloyd changed the title Add custom image.tags for all pods Add custom image.tag for all pods Jun 19, 2021
@ericreeves
Copy link
Contributor

+1. Yes please.

This would allow me to easily utilize stable 3.4 containers with stackstorm-ha without having to maintain a patched Charts.yaml or a big Kustomize patch!

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Thanks for the helpful addition 👍

@arm4b arm4b merged commit 2e2efe8 into StackStorm:master Jun 26, 2021
@cognifloyd cognifloyd removed the RFR label Jun 26, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jun 29, 2021
@cognifloyd
Copy link
Member Author

Oops. I missed one tag in a helper template. Pushed a follow up in #214.

cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jun 29, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jun 29, 2021
arm4b added a commit that referenced this pull request Jun 29, 2021
Fix tag in helper (follow up to #200)
ericreeves pushed a commit to alertlogic/stackstorm-ha that referenced this pull request Jul 9, 2021
@cognifloyd cognifloyd deleted the image-tags branch November 11, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants