Skip to content

support for custom st2actionrunner images via values.yaml #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 13, 2022
Merged

support for custom st2actionrunner images via values.yaml #141

merged 9 commits into from
Jul 13, 2022

Conversation

@Sheshagiri
Copy link
Contributor

@Sheshagiri Sheshagiri commented Jul 15, 2020 •
edited by cognifloyd
Loading

This pr adds support for providing custom st2actionrunner-specific docker repository, image name, pull policy, and pull secret via values.yaml.

closes: #104

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Jul 15, 2020
arm4b
arm4b reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Note that a Changelog update is also needed to merge this.

@arm4b arm4b added the enhancement New feature or request label Jul 16, 2020
@Sheshagiri Sheshagiri changed the title [WIP]support for custom st2actionrunner images via values.yaml support for custom st2actionrunner images via values.yaml Jul 16, 2020
@Sheshagiri Sheshagiri marked this pull request as ready for review July 16, 2020 18:59
@Sheshagiri
Copy link
Contributor Author

Sheshagiri commented Jul 16, 2020

@armab this is ready for review the following todo's

  • actual testing on a real K8s cluster
  • update release notes and readme

arm4b
arm4b reviewed Jul 16, 2020
View reviewed changes
templates/_helpers.tpl Outdated
{{- end -}}

# Generate Docker image repository for st2actionrunner: Private 'docker.stackstorm.com' for Enterprise vs Public Docker Hub 'stackstorm' for FOSS version
{{- define "st2actionrunnerImageRepository" -}}
Copy link
Member

@arm4b arm4b Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity reasons, it would be easier to avoid custom template for st2actionrunner, if possible. I saw the previous version, wondering if that worked good?

@arm4b arm4b mentioned this pull request Aug 11, 2020
Merged
cognifloyd
cognifloyd reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still needed? If so, can you rebase it or merge in master?
Enterprise stuff has been removed, so at least some of this can be simplified.

@Sheshagiri
Copy link
Contributor Author

Sheshagiri commented Jun 22, 2021

@cognifloyd will take a look at this, this week.

@cognifloyd
Copy link
Member

cognifloyd commented Jun 26, 2021

#200 was just merged, so you can have custom image tags for any of the pods, including st2actionrunner. Hopefully that simplifies things for you @Sheshagiri .

@cognifloyd
Copy link
Member

cognifloyd commented Sep 12, 2021

@Sheshagiri I looked into resolving the conflicts for you to merge master into your branch, but Maintainer edits are not turned on.

Would you please merge in master? I'd love to merge this once we get it ready.

@CLAassistant
Copy link

CLAassistant commented May 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cognifloyd cognifloyd removed the stale label Jul 10, 2022
@cognifloyd
Copy link
Member

cognifloyd commented Jul 10, 2022

@Sheshagiri I merged in master and addressed @armab's feedback by dropping the additional helper.
Does this do what you were hoping for?

@cognifloyd cognifloyd requested a review from arm4b July 11, 2022 15:06
@pull-request-size pull-request-size bot added size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Jul 11, 2022
cognifloyd
cognifloyd approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K. I added unit tests.

@armab would you please review this?
I changed quite a bit, so I need another pair of eyes before it gets merged.

@cognifloyd cognifloyd removed the WIP label Jul 11, 2022
arm4b
arm4b approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I guess st2actionrunner is the image adopters would want to override more than other components.

@cognifloyd
Copy link
Member

cognifloyd commented Jul 12, 2022

Yeah that's what I figure. Thanks!

@cognifloyd cognifloyd enabled auto-merge July 12, 2022 20:37
@cognifloyd cognifloyd merged commit f47b7b1 into StackStorm:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

+1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

st2actionrunner custom image in values.yaml file

4 participants

@Sheshagiri @cognifloyd @CLAassistant @arm4b